cache lines that should be ignored by analyser

Author: d-biehl

robotcode/language_server/robotframework/diagnostics/analyzer.py

@@ -239,21 +239,34 @@ async def visit(self, node: ast.AST) -> None:
         finally:
             self.node_stack = self.node_stack[:-1]
 
+    @staticmethod
+    async def get_ignored_lines(document: TextDocument) -> List[int]:
+        return await document.get_cache(Analyzer.__get_ignored_lines)
+
+    @staticmethod
+    async def __get_ignored_lines(document: TextDocument) -> List[int]:
+        result = []
+        lines = await document.get_lines()
+        for line_no, line in enumerate(lines):
+
+            comment = EXTRACT_COMMENT_PATTERN.match(line)
+            if comment and comment.group("comment"):
+                for match in ROBOTCODE_PATTERN.finditer(comment.group("comment")):
+
+                    if match.group("rule") == "ignore":
+                        result.append(line_no)
+
+        return result
+
     @staticmethod
     async def should_ignore(document: Optional[TextDocument], range: Range) -> bool:
         import builtins
 
         if document is not None:
-            lines = await document.get_lines()
+            lines = await Analyzer.get_ignored_lines(document)
             for line_no in builtins.range(range.start.line, range.end.line + 1):
-                line = lines[line_no]
-
-                comment = EXTRACT_COMMENT_PATTERN.match(line)
-                if comment and comment.group("comment"):
-                    for match in ROBOTCODE_PATTERN.finditer(comment.group("comment")):
-
-                        if match.group("rule") == "ignore":
-                            return True
+                if line_no in lines:
+                    return True
 
         return False
 

robotcode/language_server/robotframework/diagnostics/namespace.py

@@ -856,7 +856,6 @@ async def get_global_variables(self) -> List[VariableDefinition]:
 
         return self._global_variables
 
-    @_logger.call
     async def yield_variables(
         self,
         nodes: Optional[List[ast.AST]] = None,
@@ -906,7 +905,6 @@ async def get_resolvable_variables(
             if v.has_value
         }
 
-    @_logger.call
     async def get_variable_matchers(
         self, nodes: Optional[List[ast.AST]] = None, position: Optional[Position] = None
     ) -> Dict[VariableMatcher, VariableDefinition]:
@@ -945,7 +943,6 @@ async def find_variable(
 
         return None
 
-    @_logger.call
     async def _import_imports(
         self,
         imports: Iterable[Import],