fix(core): handle json from_dict correctly for optinal types

Author: d-biehl

packages/core/src/robotcode/core/utils/dataclasses.py

@@ -419,6 +419,9 @@ def from_dict(
         match_type_hints: Optional[Dict[str, Any]] = None
 
         for t in types:
+            if t is type(None):
+                continue
+
             origin = _get_origin_cached(t)
 
             if origin is Literal:
@@ -455,7 +458,7 @@ def from_dict(
                 match_type_hints = type_hints
             elif match_same_keys is not None and len(match_same_keys) == len(same_keys):
                 raise TypeError(
-                    f"Value {value!r} matches to more then one types of "
+                    f"Value {value!r} of type {type(value)!r} matches to more then one types of "
                     f"{repr(types[0].__name__) if len(types) == 1 else ' | '.join(repr(e.__name__) for e in types)}."
                 )
 

tests/robotcode/core/test_dataclasses.py

@@ -594,6 +594,30 @@ def test_literal_with_invalid_args_should_raise_typerror(expr: Any, type: Any) -
         from_json(expr, type)
 
 
+@dataclass
+class SimpleData:
+    a: Optional[int] = None
+    b: Optional[str] = None
+
+
+@dataclass
+class ComplexData:
+    data: Optional[SimpleData] = None
+    more_data: Optional[str] = None
+
+
+@pytest.mark.parametrize(
+    ("expr", "type", "expected"),
+    [
+        ('{"a":1, "b":"2"}', Optional[SimpleData], SimpleData(1, "2")),
+        ("{}", Optional[SimpleData], SimpleData()),
+        ("{}", Optional[ComplexData], ComplexData()),
+    ],
+)
+def test_empty_dict_should_not_match_none_type(expr: Any, type: Any, expected: str) -> None:
+    assert from_json(expr, type, strict=True) == expected
+
+
 @dataclass
 class SimpleItemWithAlias:
     a: int = field(metadata={"alias": "a_test"})