perf(analyzer): optimization of the analysis of imports, accelerated by a factor of 3

Author: d-biehl

packages/language_server/src/robotcode/language_server/common/parts/diagnostics.py

@@ -109,6 +109,8 @@ def __init__(self, protocol: "LanguageServerProtocol") -> None:
         self.refresh_timer_lock = RLock()
         self.refresh_timer: Optional[Timer] = None
 
+        self.break_diagnostics_timer_lock = RLock()
+        self.break_diagnostics_timer: Optional[Timer] = None
         self._break_diagnostics_loop_event = Event()
 
         self._current_diagnostics_task_lock = RLock()
@@ -226,7 +228,20 @@ def cancel_workspace_diagnostics_task(self, sender: Any) -> None:
         if self._workspace_diagnostics_task is not None and not self._workspace_diagnostics_task.done():
             self._workspace_diagnostics_task.cancel()
 
-    def break_workspace_diagnostics_loop(self) -> None:
+    def break_workspace_diagnostics_loop(self, now: bool = False) -> None:
+        with self.break_diagnostics_timer_lock:
+            if self.break_diagnostics_timer is not None:
+                self.break_diagnostics_timer.cancel()
+                self.break_diagnostics_timer = None
+
+            if not now:
+                self.break_diagnostics_timer = Timer(1, self._break_workspace_diagnostics_loop)
+                self.break_diagnostics_timer.start()
+                return
+
+        self._break_workspace_diagnostics_loop()
+
+    def _break_workspace_diagnostics_loop(self) -> None:
         self._break_diagnostics_loop_event.set()
         with self._current_diagnostics_task_lock(timeout=self._diagnostics_task_timeout * 2):
             if self._current_diagnostics_task is not None and not self._current_diagnostics_task.done():

packages/robot/src/robotcode/robot/diagnostics/document_cache_helper.py

@@ -433,15 +433,15 @@ def __invalidate_namespace(self, sender: Namespace) -> None:
 
     def __namespace_initialized(self, sender: Namespace) -> None:
         if sender.document is not None:
-            self._logger.critical(
+            self._logger.debug(
                 lambda: f"Save initialized Namespace: {sender.document.uri if sender.document else None}"
             )
             sender.document.set_data(self.INITIALIZED_NAMESPACE, sender)
 
     def get_initialized_namespace(self, document: TextDocument) -> Namespace:
         result: Optional[Namespace] = document.get_data(self.INITIALIZED_NAMESPACE)
         if result is None:
-            self._logger.critical(lambda: f"There is not initialized Namespace: {document.uri if document else None}")
+            self._logger.debug(lambda: f"There is no initialized Namespace: {document.uri if document else None}")
             result = self.get_namespace(document)
         return result
 

packages/robot/src/robotcode/robot/diagnostics/imports_manager.py

@@ -561,9 +561,9 @@ def __init__(
         if environment:
             self._environment.update(environment)
 
-        self._library_files_cache = SimpleLRUCache()
-        self._resource_files_cache = SimpleLRUCache()
-        self._variables_files_cache = SimpleLRUCache()
+        self._library_files_cache = SimpleLRUCache(1024)
+        self._resource_files_cache = SimpleLRUCache(1024)
+        self._variables_files_cache = SimpleLRUCache(1024)
 
         self._executor_lock = RLock(default_timeout=120, name="ImportsManager._executor_lock")
         self._executor: Optional[ProcessPoolExecutor] = None
@@ -1400,13 +1400,17 @@ def get_libdoc_for_variables_import(
     ) -> VariablesDoc:
         source = self.find_variables(name, base_dir, variables, resolve_variables, resolve_command_line_vars)
 
-        resolved_args = resolve_args(
-            args,
-            str(self.root_folder),
-            base_dir,
-            self.get_resolvable_command_line_variables() if resolve_command_line_vars else None,
-            variables,
-        )
+        if args:
+            resolved_args = resolve_args(
+                args,
+                str(self.root_folder),
+                base_dir,
+                self.get_resolvable_command_line_variables() if resolve_command_line_vars else None,
+                variables,
+            )
+        else:
+            resolved_args = ()
+
         entry_key = _VariablesEntryKey(source, resolved_args)
 
         with self._variables_lock: