refactor: make mypy and ruff happy

Author: d-biehl

packages/core/src/robotcode/core/logging.py

@@ -109,7 +109,7 @@ class LoggingDescriptor:
 
     def __init__(
         self,
-        _func: _FUNC_TYPE = None,
+        _func: Optional[_FUNC_TYPE] = None,
         *,
         name: Optional[str] = None,
         postfix: str = "",
@@ -172,7 +172,7 @@ def __set_name__(self, owner: Any, name: str) -> None:
         self.__owner = owner
         self.__owner_name = name
 
-    def __call__(self, _func: _FUNC_TYPE = None) -> LoggingDescriptor:
+    def __call__(self, _func: Optional[_FUNC_TYPE] = None) -> LoggingDescriptor:
         if _func is not None:
             self.__func = _func
 

packages/core/src/robotcode/core/utils/process.py

@@ -1,3 +1,5 @@
+# mypy: disable-error-code="attr-defined"
+
 import os
 
 __all__ = ["pid_exists"]

packages/debugger/src/robotcode/debugger/debugger.py

@@ -848,7 +848,7 @@ def start_keyword(self, name: str, attributes: Dict[str, Any]) -> None:
 
             self.wait_for_running()
 
-    CAUGHTED_KEYWORDS: ClassVar = [
+    CAUGHTED_KEYWORDS: ClassVar[List[str]] = [
         "BuiltIn.Run Keyword And Expect Error",
         "BuiltIn.Run Keyword And Ignore Error",
         "BuiltIn.Run Keyword And Warn On Failure",
@@ -984,7 +984,7 @@ def yield_stack() -> Iterator[StackFrame]:
 
         return StackTraceResult(frames, len(self.stack_frames))
 
-    MESSAGE_COLORS: ClassVar = {
+    MESSAGE_COLORS: ClassVar[Dict[str, str]] = {
         "INFO": "\u001b[38;5;2m",
         "WARN": "\u001b[38;5;3m",
         "ERROR": "\u001b[38;5;1m",

packages/language_server/src/robotcode/language_server/common/parts/completion.py

@@ -161,6 +161,4 @@ async def _completion_item_resolve(
 
         if len(results) > 1:
             self._logger.warning("More then one resolve result. Use the last one.")
-        result = results[-1]
-
-        return result
+        return results[-1]

packages/language_server/src/robotcode/language_server/robotframework/parts/codelens.py

@@ -128,7 +128,7 @@ async def resolve(self, sender: Any, code_lens: CodeLens) -> Optional[CodeLens]:
 
                     async def find_refs() -> None:
                         if document is None or kw_doc is None:
-                            return
+                            return  #  type: ignore[unreachable]
 
                         await self.parent.robot_references.find_keyword_references(
                             document, kw_doc, include_declaration=False

packages/language_server/src/robotcode/language_server/robotframework/parts/completion.py

@@ -11,6 +11,7 @@
     AsyncIterator,
     Awaitable,
     Callable,
+    ClassVar,
     Dict,
     Iterable,
     Iterator,
@@ -451,7 +452,7 @@ async def create_environment_variables_completion_items(self, range: Optional[Ra
             for s in self.namespace.imports_manager.environment.keys()
         ]
 
-    _VARIABLE_COMPLETION_SORT_TEXT_PREFIX = {
+    _VARIABLE_COMPLETION_SORT_TEXT_PREFIX: ClassVar[Dict[VariableDefinitionType, str]] = {
         VariableDefinitionType.LOCAL_VARIABLE: "033",
         VariableDefinitionType.ARGUMENT: "034",
         VariableDefinitionType.VARIABLE: "035",

packages/language_server/src/robotcode/language_server/robotframework/protocol.py

@@ -2,7 +2,7 @@
 import sys
 from dataclasses import dataclass, field
 from pathlib import Path
-from typing import TYPE_CHECKING, Any, Dict, Final, List, Optional
+from typing import TYPE_CHECKING, Any, ClassVar, Dict, Final, List, Optional, Set
 
 from robotcode.core.dataclasses import CamelSnakeMixin, from_dict
 from robotcode.core.logging import LoggingDescriptor
@@ -106,9 +106,9 @@ class RobotLanguageServerProtocol(LanguageServerProtocol):
     short_name = "RobotCode"
     version = __version__
 
-    file_extensions = {"robot", "resource", "py", "yaml", "yml"}
+    file_extensions: ClassVar[Set[str]] = {"robot", "resource", "py", "yaml", "yml"}
 
-    languages = [
+    languages: ClassVar[List[LanguageDefinition]] = [
         LanguageDefinition(
             id="robotframework",
             extensions=[".robot", ".resource"],

packages/robot/src/robotcode/robot/config/model.py

@@ -2197,7 +2197,9 @@ class RobotConfig(RobotExtraBaseProfile):
         metadata={"description": "Tool configuration."},
     )
 
-    def select_profiles(self, *names: str, verbose_callback: Callable[..., None] = None) -> Dict[str, RobotProfile]:
+    def select_profiles(
+        self, *names: str, verbose_callback: Optional[Callable[..., None]] = None
+    ) -> Dict[str, RobotProfile]:
         result: Dict[str, RobotProfile] = {}
 
         profiles = self.profiles or {}
@@ -2226,7 +2228,7 @@ def select_profiles(self, *names: str, verbose_callback: Callable[..., None] = N
 
         return result
 
-    def combine_profiles(self, *names: str, verbose_callback: Callable[..., None] = None) -> RobotBaseProfile:
+    def combine_profiles(self, *names: str, verbose_callback: Optional[Callable[..., None]] = None) -> RobotBaseProfile:
         type_hints = get_type_hints(RobotBaseProfile)
         base_field_names = [f.name for f in dataclasses.fields(RobotBaseProfile)]
 

pyproject.toml

@@ -165,7 +165,7 @@ fail_under = 40
 line-length = 120
 target-version = "py38"
 extend-exclude = ["bundled/libs"]
-ignore = ["E741", "N805", "N999"]
+ignore = ["E741", "N805", "N999", "RUF012"]
 select = [
   "E",
   "F",