Skip to content

Commit b00b6cc

Browse files
stephane-caronStéphane Caron
authored andcommitted
Strip cache population as it is not necessary
Issues with Pinocchio unit tests lie elsewhere and are now documented. See #6
1 parent 2cb22f8 commit b00b6cc

File tree

5 files changed

+1
-22
lines changed

5 files changed

+1
-22
lines changed

CHANGELOG.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@ All notable changes to this project will be documented in this file.
2424
- Match cache path with package name when it helps PyBullet
2525
- Remove ``MESHES_PATH`` attribute
2626

27-
### Fixed
28-
29-
- CI: Populate cache before running unit tests
30-
3127
## [0.3.0] - 2022/09/12
3228

3329
### Added

robot_descriptions/__init__.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,3 @@
2020
"""
2121

2222
__version__ = "0.4.0rc1"
23-
24-
from ._cache import populate_cache
25-
26-
__all__ = ["populate_cache"]

robot_descriptions/_cache.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -119,15 +119,3 @@ def clone_to_cache(description_name: str) -> str:
119119
clone = clone_to_directory(repository.url, target_dir)
120120
clone.git.checkout(repository.commit)
121121
return str(clone.working_dir)
122-
123-
124-
def populate_cache() -> None:
125-
"""
126-
Clone all repositories to cache.
127-
128-
Notes:
129-
This function can be used for unit testing, or before another program
130-
that wants to make sure robot descriptions are imported right away.
131-
"""
132-
for description_name in REPOSITORIES:
133-
clone_to_cache(description_name)

tests/test_cache.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
from robot_descriptions._repositories import REPOSITORIES
3131

3232

33-
class TestGit(unittest.TestCase):
33+
class TestCache(unittest.TestCase):
3434

3535
"""
3636
Test fixture for git-related functions.

tox.ini

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ commands =
2727
flake8 robot_descriptions
2828
pylint robot_descriptions --exit-zero --rcfile={toxinidir}/tox.ini
2929
mypy robot_descriptions --ignore-missing-imports
30-
python -c "from robot_descriptions import populate_cache; populate_cache()"
3130
coverage erase
3231
coverage run -m unittest discover
3332
coverage report --include="robot_descriptions/*"

0 commit comments

Comments
 (0)