Skip to content

Commit 9bcb0ba

Browse files
stephane-caronStéphane Caron
authored andcommitted
Make an exception for bolt_description in pinocchio tests
1 parent 5d25a25 commit 9bcb0ba

File tree

2 files changed

+53
-50
lines changed

2 files changed

+53
-50
lines changed

robot_descriptions/_descriptions.py

Lines changed: 50 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -71,56 +71,56 @@ def has_urdf(self) -> bool:
7171

7272

7373
DESCRIPTIONS: Dict[str, Description] = {
74-
# "a1_description": Description(Format.URDF),
75-
# "a1_mj_description": Description(Format.MJCF),
76-
# "aliengo_description": Description(Format.MJCF),
77-
# "allegro_hand_description": Description(Format.URDF),
78-
# "anymal_b_description": Description(Format.URDF),
79-
# "anymal_b_mj_description": Description(Format.MJCF),
80-
# "anymal_c_description": Description(Format.URDF),
81-
# "anymal_c_mj_description": Description(Format.MJCF),
82-
# "atlas_drc_description": Description(Format.URDF),
83-
# "atlas_v4_description": Description(Format.URDF),
84-
# "baxter_description": Description(Format.URDF),
74+
"a1_description": Description(Format.URDF),
75+
"a1_mj_description": Description(Format.MJCF),
76+
"aliengo_description": Description(Format.MJCF),
77+
"allegro_hand_description": Description(Format.URDF),
78+
"anymal_b_description": Description(Format.URDF),
79+
"anymal_b_mj_description": Description(Format.MJCF),
80+
"anymal_c_description": Description(Format.URDF),
81+
"anymal_c_mj_description": Description(Format.MJCF),
82+
"atlas_drc_description": Description(Format.URDF),
83+
"atlas_v4_description": Description(Format.URDF),
84+
"baxter_description": Description(Format.URDF),
8585
"bolt_description": Description(Format.URDF),
8686
"cassie_description": Description(Format.URDF),
87-
# "cassie_mj_description": Description(Format.MJCF),
88-
# "cf2_description": Description(Format.URDF),
89-
# "double_pendulum_description": Description(Format.URDF),
90-
# "edo_description": Description(Format.URDF),
91-
# "fetch_description": Description(Format.URDF),
92-
# "finger_edu_description": Description(Format.URDF),
93-
# "gen2_description": Description(Format.URDF),
94-
# "ginger_description": Description(Format.URDF),
95-
# "go1_description": Description(Format.URDF),
96-
# "go1_mj_description": Description(Format.MJCF),
97-
# "hyq_description": Description(Format.URDF),
98-
# "icub_description": Description(Format.URDF),
99-
# "iiwa_description": Description(Format.URDF),
100-
# "jvrc_description": Description(Format.URDF),
101-
# "jvrc_mj_description": Description(Format.MJCF),
102-
# "laikago_description": Description(Format.URDF),
103-
# "mini_cheetah_description": Description(Format.URDF),
104-
# "minitaur_description": Description(Format.URDF),
105-
# "panda_description": Description(Format.URDF),
106-
# "panda_mj_description": Description(Format.MJCF),
107-
# "pepper_description": Description(Format.URDF),
108-
# "poppy_ergo_jr_description": Description(Format.URDF),
109-
# "poppy_torso_description": Description(Format.URDF),
110-
# "pr2_description": Description(Format.URDF),
111-
# "reachy_description": Description(Format.URDF),
112-
# "robotiq_2f85_description": Description(Format.URDF),
113-
# "robotiq_2f85_mj_description": Description(Format.MJCF),
114-
# "romeo_description": Description(Format.URDF),
115-
# "shadow_hand_mj_description": Description(Format.MJCF),
116-
# "simple_humanoid_description": Description(Format.URDF),
117-
# "solo_description": Description(Format.URDF),
118-
# "talos_description": Description(Format.URDF),
119-
# "tiago_description": Description(Format.URDF),
120-
# "upkie_description": Description(Format.URDF),
121-
# "ur10_description": Description(Format.URDF),
122-
# "ur3_description": Description(Format.URDF),
123-
# "ur5_description": Description(Format.URDF),
124-
# "ur5e_mj_description": Description(Format.MJCF),
125-
# "yumi_description": Description(Format.URDF),
87+
"cassie_mj_description": Description(Format.MJCF),
88+
"cf2_description": Description(Format.URDF),
89+
"double_pendulum_description": Description(Format.URDF),
90+
"edo_description": Description(Format.URDF),
91+
"fetch_description": Description(Format.URDF),
92+
"finger_edu_description": Description(Format.URDF),
93+
"gen2_description": Description(Format.URDF),
94+
"ginger_description": Description(Format.URDF),
95+
"go1_description": Description(Format.URDF),
96+
"go1_mj_description": Description(Format.MJCF),
97+
"hyq_description": Description(Format.URDF),
98+
"icub_description": Description(Format.URDF),
99+
"iiwa_description": Description(Format.URDF),
100+
"jvrc_description": Description(Format.URDF),
101+
"jvrc_mj_description": Description(Format.MJCF),
102+
"laikago_description": Description(Format.URDF),
103+
"mini_cheetah_description": Description(Format.URDF),
104+
"minitaur_description": Description(Format.URDF),
105+
"panda_description": Description(Format.URDF),
106+
"panda_mj_description": Description(Format.MJCF),
107+
"pepper_description": Description(Format.URDF),
108+
"poppy_ergo_jr_description": Description(Format.URDF),
109+
"poppy_torso_description": Description(Format.URDF),
110+
"pr2_description": Description(Format.URDF),
111+
"reachy_description": Description(Format.URDF),
112+
"robotiq_2f85_description": Description(Format.URDF),
113+
"robotiq_2f85_mj_description": Description(Format.MJCF),
114+
"romeo_description": Description(Format.URDF),
115+
"shadow_hand_mj_description": Description(Format.MJCF),
116+
"simple_humanoid_description": Description(Format.URDF),
117+
"solo_description": Description(Format.URDF),
118+
"talos_description": Description(Format.URDF),
119+
"tiago_description": Description(Format.URDF),
120+
"upkie_description": Description(Format.URDF),
121+
"ur10_description": Description(Format.URDF),
122+
"ur3_description": Description(Format.URDF),
123+
"ur5_description": Description(Format.URDF),
124+
"ur5e_mj_description": Description(Format.MJCF),
125+
"yumi_description": Description(Format.URDF),
126126
}

tests/test_pinocchio.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ def test(self):
6565

6666
VALUE_ERROR_ISSUE = {
6767
"anymal_b_description",
68+
"bolt_description",
6869
}
6970

7071
for name, description in DESCRIPTIONS.items():
@@ -75,6 +76,8 @@ def test(self):
7576
continue
7677
if name in VALUE_ERROR_ISSUE:
7778
# ValueError: Argument geometry_model should be a GeometryModel
79+
# TODO(scaron): I'm not sure why these descriptions fail to load in the
80+
# CI while they load fine on my machine locally (py38, pin-2.6.4)
7881
continue
7982
if description.has_urdf:
8083
setattr(

0 commit comments

Comments
 (0)