Fix CID #1610086: unchecked return

ni4 · ronaldtse · commit 7a9264c70075 · 2025-05-20T07:32:50.000+08:00
diff --git a/src/rnp/fficli.cpp b/src/rnp/fficli.cpp
@@ -2022,8 +2022,7 @@ cli_rnp_t::keys_matching(std::vector<rnp_key_handle_t> & keys,
             ERR_MSG("No userid or default key for operation");
             return false;
         }
-        keys_matching(keys, defkey(), flags & ~CLI_SEARCH_DEFAULT);
-        if (keys.empty()) {
+        if (!keys_matching(keys, defkey(), flags & ~CLI_SEARCH_DEFAULT) || keys.empty()) {
             ERR_MSG("Default key not found");
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -2022,8 +2022,7 @@ cli_rnp_t::keys_matching(std::vector<rnp_key_handle_t> & keys,`
`2022`	`2022`	`ERR_MSG("No userid or default key for operation");`
`2023`	`2023`	`return false;`
`2024`	`2024`	`}`
`2025`		`- keys_matching(keys, defkey(), flags & ~CLI_SEARCH_DEFAULT);`
`2026`		`- if (keys.empty()) {`
	`2025`	`+ if (!keys_matching(keys, defkey(), flags & ~CLI_SEARCH_DEFAULT) \|\| keys.empty()) {`
`2027`	`2026`	`ERR_MSG("Default key not found");`
`2028`	`2027`	`}`
`2029`	`2028`	`}`