chore: log warning in ws connection was not closed cleanly (#858)

Author: NathanFlurry

packages/actor-core/src/actor/router.ts

@@ -169,11 +169,23 @@ export function createActorRouter(
 								ws.close(1011, code);
 							}
 						},
-						onClose: async (_evt) => {
+						onClose: async (event) => {
 							try {
 								await onOpenPromise;
 
-								logger().debug("websocket closed");
+								if (event.wasClean) {
+									logger().info("websocket closed", {
+										code: event.code,
+										reason: event.reason,
+										wasClean: event.wasClean,
+									});
+								} else {
+									logger().warn("websocket closed", {
+										code: event.code,
+										reason: event.reason,
+										wasClean: event.wasClean,
+									});
+								}
 
 								await wsHandler.onClose();
 							} catch (error) {
@@ -186,9 +198,7 @@ export function createActorRouter(
 
 								// Actors don't need to know about this, since it's abstracted
 								// away
-								logger().warn("websocket error", {
-									error: stringifyError(error),
-								});
+								logger().warn("websocket error");
 							} catch (error) {
 								deconstructError(error, logger(), { wsEvent: "error" });
 							}

packages/actor-core/src/client/handle.ts

@@ -382,11 +382,20 @@ enc
 		//
 		// These properties will be undefined
 		const closeEvent = event as CloseEvent;
-		logger().debug("socket closed", {
-			code: closeEvent.code,
-			reason: closeEvent.reason,
-			wasClean: closeEvent.wasClean,
-		});
+		console.log('close event', JSON.stringify(event));
+		if (closeEvent.wasClean) {
+			logger().info("socket closed", {
+				code: closeEvent.code,
+				reason: closeEvent.reason,
+				wasClean: closeEvent.wasClean,
+			});
+		} else {
+			logger().warn("socket closed", {
+				code: closeEvent.code,
+				reason: closeEvent.reason,
+				wasClean: closeEvent.wasClean,
+			});
+		}
 
 		this.#transport = undefined;
 
@@ -404,6 +413,8 @@ enc
 	/** Called by the onerror event from drivers. */
 	#handleOnError(event: Event) {
 		if (this.#disposed) return;
+
+		// More detailed information will be logged in onclose
 		logger().warn("socket error", { event });
 	}