Skip to content

fix(rivetkit): remove incorrect getEndpoint call in metadata handler #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 11-09-feat_rivetkit_add_json_protocol_support
Choose a base branch
from
Open

fix(rivetkit): remove incorrect getEndpoint call in metadata handler #3433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions rivetkit-typescript/packages/rivetkit/src/common/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import {
} from "@/actor/router-endpoints";
import { buildActorNames, type RegistryConfig } from "@/registry/config";
import type { RunnerConfig } from "@/registry/run-config";
import { getEndpoint } from "@/remote-manager-driver/api-utils";
import type * as protocol from "@/schemas/client-protocol/mod";
import { HTTP_RESPONSE_ERROR_VERSIONED } from "@/schemas/client-protocol/versioned";
import {
Expand Down Expand Up @@ -139,12 +138,10 @@ export function handleMetadataRequest(
: { normal: {} },
},
actorNames: buildActorNames(registryConfig),
// Do not return client endpoint if default server disabled
clientEndpoint:
runConfig.overrideServerAddress ??
(runConfig.disableDefaultServer
? undefined
: getEndpoint(runConfig)),
// If server address is changed, return a different client endpoint.
// Otherwise, return null indicating the client should use the current
// endpoint it's already configured with.
clientEndpoint: runConfig.overrideServerAddress,
};

return c.json(response);
Expand Down
Loading