options.c: option --help should yield exit code 0

R. Diez · borneoa · commit 4deb76fc9d48 · 2025-02-16T16:28:07.000Z
--help is supported and there is no reason to signal failure Change-Id: I59fda5336df47ec0b8172541a5fbfe60014bba7e Signed-off-by: R. Diez <rdiezmail-openocd@yahoo.de> Reviewed-on: https://review.openocd.org/c/openocd/+/8723 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
diff --git a/src/helper/options.c b/src/helper/options.c
@@ -334,7 +334,7 @@ int parse_cmdline_args(struct command_context *cmd_ctx, int argc, char *argv[])
 		LOG_OUTPUT("             | -d<n>\tset debug level to <level>\n");
 		LOG_OUTPUT("--log_output | -l\tredirect log output to file <name>\n");
 		LOG_OUTPUT("--command    | -c\trun <command>\n");
-		exit(-1);
+		exit(0);
 	}
 
 	if (version_flag) {

Original file line number	Diff line number	Diff line change
`@@ -334,7 +334,7 @@ int parse_cmdline_args(struct command_context cmd_ctx, int argc, char argv[])`
`334`	`334`	`LOG_OUTPUT(" \| -d<n>\tset debug level to <level>\n");`
`335`	`335`	`LOG_OUTPUT("--log_output \| -l\tredirect log output to file <name>\n");`
`336`	`336`	`LOG_OUTPUT("--command \| -c\trun <command>\n");`
`337`		`- exit(-1);`
	`337`	`+ exit(0);`
`338`	`338`	`}`
`339`	`339`
`340`	`340`	`if (version_flag) {`