Skip to content

Bugfix: Make util/request-url handle empty query string #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bugfix: Make util/request-url handle empty query string #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ring-core/src/ring/util/request.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"://"
(get-in request [:headers "host"])
(:uri request)
(when-let [query (:query-string request)]
(when-let [query (not-empty (:query-string request))]
(str "?" query))))

(defn content-type
Expand Down
5 changes: 5 additions & 0 deletions ring-core/test/ring/util/test/request.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@
(is (= (request-url {:scheme :https
:uri "/index.html"
:headers {"host" "www.example.com"}})
"https://www.example.com/index.html"))
(is (= (request-url {:scheme :https
:uri "/index.html"
:headers {"host" "www.example.com"}
:query-string ""})
"https://www.example.com/index.html")))

(deftest test-content-type
Expand Down
Loading