Do not inline length of j strings.

Author: cristianoc

jscomp/core/js_exp_make.ml

@@ -475,7 +475,7 @@ let array_length ?comment (e : t) : t =
 
 let string_length ?comment (e : t) : t =
   match e.expression_desc with
-  | Str {txt} -> int ?comment (Int32.of_int (String.length txt))
+  | Str {txt; delim=None} -> int ?comment (Int32.of_int (String.length txt))
   (* No optimization for {j||j}*)
   | _ -> { expression_desc = Length (e, String); comment }
 

jscomp/test/chn_test.js

@@ -183,7 +183,7 @@ eq("File \"chn_test.ml\", line 63, characters 5-12", convert("\uD83D\uDE80\uD83D
       }
     });
 
-eq("No inline string length", 14, 3);
+eq("No inline string length", "\uD83D\uDE80\0".length, 3);
 
 eq("File \"chn_test.ml\", line 72, characters 6-13", Caml_string.get("\uD83D\uDE80\0", 0), 128640);
 

lib/4.06.1/unstable/js_compiler.ml

@@ -67731,7 +67731,7 @@ let array_length ?comment (e : t) : t =
 
 let string_length ?comment (e : t) : t =
   match e.expression_desc with
-  | Str {txt} -> int ?comment (Int32.of_int (String.length txt))
+  | Str {txt; delim=None} -> int ?comment (Int32.of_int (String.length txt))
   (* No optimization for {j||j}*)
   | _ -> { expression_desc = Length (e, String); comment }
 

lib/4.06.1/unstable/js_playground_compiler.ml

@@ -67731,7 +67731,7 @@ let array_length ?comment (e : t) : t =
 
 let string_length ?comment (e : t) : t =
   match e.expression_desc with
-  | Str {txt} -> int ?comment (Int32.of_int (String.length txt))
+  | Str {txt; delim=None} -> int ?comment (Int32.of_int (String.length txt))
   (* No optimization for {j||j}*)
   | _ -> { expression_desc = Length (e, String); comment }
 

lib/4.06.1/whole_compiler.ml

@@ -235893,7 +235893,7 @@ let array_length ?comment (e : t) : t =
 
 let string_length ?comment (e : t) : t =
   match e.expression_desc with
-  | Str {txt} -> int ?comment (Int32.of_int (String.length txt))
+  | Str {txt; delim=None} -> int ?comment (Int32.of_int (String.length txt))
   (* No optimization for {j||j}*)
   | _ -> { expression_desc = Length (e, String); comment }