Merge pull request #4441 from BuckleScript/tweak

remove unused caml_obj_set_tag

Author: bobzhang

jscomp/core/js_of_lam_exception.ml

@@ -37,8 +37,10 @@ module E = Js_exp_make
    Note if we inline {!Caml_exceptions.create}, 
    it seems can be useful for optimizations in theory, 
    in practice, it never happen, since the pattern match 
-   never dig into it internally, so maybe {!Obj.set_tag} 
-   is not necessary at all
+   never dig into it internally.
+   Alternative is to create a block `["xx"]` which relies on object identity
+   We try to avoid this, since inlining would break this, this would make reason
+   about the correctness of inlining more difficult
 *)
 let make exception_str  : J.expression = 
   E.runtime_call Js_runtime_modules.exceptions Literals.create [exception_str]

jscomp/core/lam_dispatch_primitive.ml

@@ -706,9 +706,6 @@ let translate loc (prim_name : string)
 
       Location.prerr_warning loc Warnings.Bs_polymorphic_comparison ; 
       call Js_runtime_modules.obj_runtime
-    | "caml_obj_set_tag" 
-      -> 
-      call Js_runtime_modules.obj_runtime
     | "caml_obj_tag" -> 
       (* Note that in ocaml, [int] has tag [1000] and [string] has tag [252]
          also now we need do nullary check 

jscomp/runtime/caml_obj.ml

@@ -346,5 +346,5 @@ let caml_min (x : Obj.t) y =
 let caml_max (x : Obj.t) y =    
   if caml_compare x y >= 0 then x else y 
 
-let caml_obj_set_tag = Obj.set_tag  
+  
 

jscomp/runtime/caml_obj.mli

@@ -60,4 +60,3 @@ val caml_min :
 val caml_max : 
   t -> t -> t 
 
-val caml_obj_set_tag : Obj.t -> int -> unit 

lib/4.06.1/unstable/js_compiler.ml

@@ -111416,9 +111416,6 @@ let translate loc (prim_name : string)
 
       Location.prerr_warning loc Warnings.Bs_polymorphic_comparison ; 
       call Js_runtime_modules.obj_runtime
-    | "caml_obj_set_tag" 
-      -> 
-      call Js_runtime_modules.obj_runtime
     | "caml_obj_tag" -> 
       (* Note that in ocaml, [int] has tag [1000] and [string] has tag [252]
          also now we need do nullary check 

lib/4.06.1/unstable/js_refmt_compiler.ml

@@ -111416,9 +111416,6 @@ let translate loc (prim_name : string)
 
       Location.prerr_warning loc Warnings.Bs_polymorphic_comparison ; 
       call Js_runtime_modules.obj_runtime
-    | "caml_obj_set_tag" 
-      -> 
-      call Js_runtime_modules.obj_runtime
     | "caml_obj_tag" -> 
       (* Note that in ocaml, [int] has tag [1000] and [string] has tag [252]
          also now we need do nullary check 

lib/4.06.1/whole_compiler.ml

@@ -394010,9 +394010,6 @@ let translate loc (prim_name : string)
 
       Location.prerr_warning loc Warnings.Bs_polymorphic_comparison ; 
       call Js_runtime_modules.obj_runtime
-    | "caml_obj_set_tag" 
-      -> 
-      call Js_runtime_modules.obj_runtime
     | "caml_obj_tag" -> 
       (* Note that in ocaml, [int] has tag [1000] and [string] has tag [252]
          also now we need do nullary check 

lib/es6/caml_obj.js

@@ -394,11 +394,6 @@ function caml_max(x, y) {
   }
 }
 
-function caml_obj_set_tag(prim, prim$1) {
-  prim.TAG = prim$1;
-  
-}
-
 export {
   caml_obj_dup ,
   update_dummy ,
@@ -414,7 +409,6 @@ export {
   caml_lessequal ,
   caml_min ,
   caml_max ,
-  caml_obj_set_tag ,
 
 }
 /* No side effect */

lib/js/caml_obj.js

@@ -394,11 +394,6 @@ function caml_max(x, y) {
   }
 }
 
-function caml_obj_set_tag(prim, prim$1) {
-  prim.TAG = prim$1;
-  
-}
-
 exports.caml_obj_dup = caml_obj_dup;
 exports.update_dummy = update_dummy;
 exports.caml_compare = caml_compare;
@@ -413,5 +408,4 @@ exports.caml_lessthan = caml_lessthan;
 exports.caml_lessequal = caml_lessequal;
 exports.caml_min = caml_min;
 exports.caml_max = caml_max;
-exports.caml_obj_set_tag = caml_obj_set_tag;
 /* No side effect */