add a test case

Author: bobzhang

jscomp/test/hello_res.js

@@ -17,5 +17,18 @@ var a = b - 1 | 0;
 
 console.log("hello, res");
 
+List.length({
+      hd: 1,
+      tl: {
+        hd: 2,
+        tl: {
+          hd: 3,
+          tl: /* [] */0
+        }
+      }
+    });
+
+console.log(3);
+
 exports.a = a;
 /* b Not a pure module */

jscomp/test/hello_res.res

@@ -14,4 +14,32 @@ type t = { "x" : int }
 
 let u : t = {"x" : 3 }
 
-let h = u["x"]
+let h = u["x"]
+
+%%private(
+let {length, cons } = module (List)
+)
+
+
+
+%%private(let {length, cons} = module(List))
+
+%%private(let (a, b) = (1, 2))
+
+let {length: len, cons: c} = module(List)
+
+module H = {
+  module H1 = {
+    let v = 3
+  }
+}
+let u = {
+  let {length: l, cons} = module(List)
+  cons(l(list{1, 2, 3}), list{})
+}
+
+let h = {
+  let {v} = module(H.H1)
+  Js.log(v)
+}
+

lib/4.06.1/unstable/js_compiler.ml

@@ -405768,8 +405768,8 @@ let flattern_tuple_pattern_vb
   let pvb_pat = self.pat self vb.pvb_pat in
   let pvb_expr = self.expr self vb.pvb_expr in
   let pvb_attributes = self.attributes self vb.pvb_attributes in
-  match pvb_pat.ppat_desc with
-  | Ppat_tuple xs when List.for_all is_simple_pattern xs ->
+  match pvb_pat.ppat_desc, pvb_expr.pexp_desc with
+  | Ppat_tuple xs, _ when List.for_all is_simple_pattern xs ->
     begin match Ast_open_cxt.destruct_open_tuple pvb_expr []  with
       | Some (wholes, es, tuple_attributes)
         when
@@ -405793,6 +405793,22 @@ let flattern_tuple_pattern_vb
          pvb_loc = vb.pvb_loc;
          pvb_attributes} :: acc
     end
+  | Ppat_record (lid_pats,_),  Pexp_pack {pmod_desc= Pmod_ident id} 
+    ->
+    Ext_list.map_append lid_pats acc (fun (lid,pat) -> 
+        match lid.txt with 
+        | Lident s ->
+          {
+            pvb_pat = pat;
+            pvb_expr = 
+              Ast_helper.Exp.ident ~loc:lid.loc
+                ({lid with txt = Ldot(id.txt,s)});
+            pvb_attributes  = [];
+            pvb_loc = pat.ppat_loc; 
+          }
+        | _ -> 
+          Location.raise_errorf ~loc:lid.loc "Not supported pattern match on modules"
+      )
   | _ ->
     {pvb_pat ;
      pvb_expr ;
@@ -406048,13 +406064,17 @@ let expr_mapper  (self : mapper) (e : Parsetree.expression) =
              pvb_attributes; 
              pvb_loc = _}], body)             
           -> 
-          default_expr_mapper self 
-            {e with 
-             pexp_desc = Pexp_match(pvb_expr,
-                                    [{pc_lhs = p; pc_guard = None; 
-                                      pc_rhs = body}]);
-             pexp_attributes = e.pexp_attributes @  pvb_attributes
-            }
+          begin match pvb_expr.pexp_desc with 
+            | Pexp_pack _ -> default_expr_mapper self e 
+            | _ -> 
+              default_expr_mapper self 
+                {e with 
+                 pexp_desc = Pexp_match(pvb_expr,
+                                        [{pc_lhs = p; pc_guard = None; 
+                                          pc_rhs = body}]);
+                 pexp_attributes = e.pexp_attributes @  pvb_attributes
+                }
+          end
          (* let [@warning "a"] {a;b} = c in body 
             The attribute is attached to value binding, 
             after the transformation value binding does not exist so we attach 

lib/4.06.1/whole_compiler.ml

@@ -408810,8 +408810,8 @@ let flattern_tuple_pattern_vb
   let pvb_pat = self.pat self vb.pvb_pat in
   let pvb_expr = self.expr self vb.pvb_expr in
   let pvb_attributes = self.attributes self vb.pvb_attributes in
-  match pvb_pat.ppat_desc with
-  | Ppat_tuple xs when List.for_all is_simple_pattern xs ->
+  match pvb_pat.ppat_desc, pvb_expr.pexp_desc with
+  | Ppat_tuple xs, _ when List.for_all is_simple_pattern xs ->
     begin match Ast_open_cxt.destruct_open_tuple pvb_expr []  with
       | Some (wholes, es, tuple_attributes)
         when
@@ -408835,6 +408835,22 @@ let flattern_tuple_pattern_vb
          pvb_loc = vb.pvb_loc;
          pvb_attributes} :: acc
     end
+  | Ppat_record (lid_pats,_),  Pexp_pack {pmod_desc= Pmod_ident id} 
+    ->
+    Ext_list.map_append lid_pats acc (fun (lid,pat) -> 
+        match lid.txt with 
+        | Lident s ->
+          {
+            pvb_pat = pat;
+            pvb_expr = 
+              Ast_helper.Exp.ident ~loc:lid.loc
+                ({lid with txt = Ldot(id.txt,s)});
+            pvb_attributes  = [];
+            pvb_loc = pat.ppat_loc; 
+          }
+        | _ -> 
+          Location.raise_errorf ~loc:lid.loc "Not supported pattern match on modules"
+      )
   | _ ->
     {pvb_pat ;
      pvb_expr ;
@@ -409090,13 +409106,17 @@ let expr_mapper  (self : mapper) (e : Parsetree.expression) =
              pvb_attributes; 
              pvb_loc = _}], body)             
           -> 
-          default_expr_mapper self 
-            {e with 
-             pexp_desc = Pexp_match(pvb_expr,
-                                    [{pc_lhs = p; pc_guard = None; 
-                                      pc_rhs = body}]);
-             pexp_attributes = e.pexp_attributes @  pvb_attributes
-            }
+          begin match pvb_expr.pexp_desc with 
+            | Pexp_pack _ -> default_expr_mapper self e 
+            | _ -> 
+              default_expr_mapper self 
+                {e with 
+                 pexp_desc = Pexp_match(pvb_expr,
+                                        [{pc_lhs = p; pc_guard = None; 
+                                          pc_rhs = body}]);
+                 pexp_attributes = e.pexp_attributes @  pvb_attributes
+                }
+          end
          (* let [@warning "a"] {a;b} = c in body 
             The attribute is attached to value binding, 
             after the transformation value binding does not exist so we attach