not carrying cst in Empty which is reduandant

Author: bobzhang

jscomp/core/lam_compile_external_call.ml

@@ -101,7 +101,7 @@ let ocaml_to_js_eff
       Js_of_lam_option.get_default_undefined_from_optional raw_arg
     | Label  | Empty -> raw_arg
     | LabelCst _
-    | EmptyCst _
+    | EmptyCst 
       -> assert false in 
   match arg_type with
   | Arg_cst _ -> assert false 
@@ -176,7 +176,7 @@ let assemble_args_no_splice call_loc ffi
     match labels, args with 
     | [], _  
       -> assert (args = []) ; empty_pair
-    | { arg_label =  EmptyCst cst ; _} :: labels, args 
+    | { arg_label =  EmptyCst  ; arg_type = Arg_cst cst } :: labels, args 
     | { arg_label =  LabelCst {cst ;}; _} :: labels, args -> 
       let accs, eff = aux labels args in
       Lam_compile_const.translate_arg_cst cst :: accs, eff 
@@ -189,6 +189,7 @@ let assemble_args_no_splice call_loc ffi
         append_list acc  accs, Ext_list.append new_eff  eff
     | { arg_label = Empty  | Label | Optional   ; _ } :: _ , [] 
       -> assert false 
+    | {arg_label = EmptyCst ; _} :: _, _  -> assert false
   in 
   let args, eff = aux arg_types args  in 
   args,
@@ -203,7 +204,7 @@ let assemble_args_has_splice call_loc ffi (arg_types : specs) (args : exprs)
   let rec aux (labels : specs) (args : exprs) = 
     match labels, args with       
     | [] , _ -> assert (args = []); empty_pair
-    | { arg_label =  EmptyCst cst ; _} :: labels  , args 
+    | { arg_label =  EmptyCst ; arg_type = Arg_cst cst} :: labels  , args 
     | { arg_label =  LabelCst {cst}; _} :: labels  , args -> 
       let accs, eff = aux labels args in
       Lam_compile_const.translate_arg_cst cst :: accs, eff 
@@ -221,6 +222,7 @@ let assemble_args_has_splice call_loc ffi (arg_types : specs) (args : exprs)
       end
     | { arg_label = Empty | Label | Optional   ; _ } :: _ , [] 
       -> assert false 
+    | {arg_label = EmptyCst ;_ } :: _, _ -> assert false  
   in 
   let args, eff = aux arg_types args  in 
   args,

jscomp/main/builtin_cmi_datasets.ml

@@ -914,8 +914,8 @@ let handle_attributes
                end
              | Nolabel ->
                begin match refine_arg_type ~nolabel:true ty with
-                 | new_ty , (Arg_cst i as arg_type) ->
-                   EmptyCst i , arg_type,  arg_types
+                 | new_ty , (Arg_cst _ as arg_type) ->
+                   EmptyCst , arg_type,  arg_types
                  | new_ty , arg_type ->
                    Empty, arg_type, {param_type with ty = new_ty} :: arg_types
                end

jscomp/syntax/ast_external_process.ml

@@ -37,7 +37,7 @@ type label_noname =
   | Label 
   | LabelCst of { cst : cst  }
   | Empty 
-  | EmptyCst of cst 
+  | EmptyCst
   | Optional
 
 type label = 

jscomp/syntax/external_arg_spec.ml

@@ -55,7 +55,7 @@ type label_noname =
   | Label
   | LabelCst of { cst : cst }
   | Empty 
-  | EmptyCst of cst 
+  | EmptyCst 
   | Optional
 
 type t =