simplify offset processing

Author: bobzhang

jscomp/bsb_helper/bsb_helper_arg.ml

@@ -3,10 +3,14 @@ type key = string
 type doc = string
 type anon_fun = rev_args:string list -> unit
 
+type string_action = 
+  | Call of (string -> unit)  
+  | Set of {mutable contents : string}
+
 type spec =
-  | Set of bool ref            
-  | String of (string -> unit) 
-  | Set_string of string ref   
+  | Bool of bool ref            
+  | String of string_action 
+
 
 exception Bad of string
 
@@ -15,10 +19,6 @@ type error =
   | Unknown of string
   | Missing of string
 
-
-
-
-
 type t = (string * spec * string) list 
 
 let rec assoc3 (x : string) (l : t) =
@@ -78,17 +78,17 @@ let parse_exn  ~progname ~argv ~start (speclist : t) anonfun  =
       match assoc3 s speclist with 
       | Some action -> begin       
           begin match action with 
-            | Set r -> r := true;
+            | Bool r -> r := true;
             | String f  ->
-              if !current  < l then begin 
-                f argv.(!current);
-                incr current;
-              end else stop_raise ~progname ~error:(Missing s) speclist 
-            | Set_string r  ->
-              if !current  < l then begin 
-                r := argv.(!current);
-                incr current;
-              end else stop_raise ~progname ~error:(Missing s) speclist 
+              if !current >= l then stop_raise ~progname ~error:(Missing s) speclist 
+              else begin                 
+                let arg = argv.(!current) in 
+                incr current;  
+                match f with 
+                | Call f ->   
+                  f arg
+                | Set u -> u.contents <- arg
+              end             
           end;      
         end;      
       | None -> stop_raise ~progname ~error:(Unknown s) speclist 

jscomp/bsb_helper/bsb_helper_arg.mli

@@ -1,10 +1,13 @@
 
 
 
+type string_action = 
+  | Call of (string -> unit)  
+  | Set of {mutable contents : string}
+
 type spec =
-  | Set of bool ref            
-  | String of (string -> unit) 
-  | Set_string of string ref   
+  | Bool of bool ref            
+  | String of string_action 
 
 type key = string
 type doc = string

jscomp/main/bsb_helper_main.ml

@@ -23,7 +23,9 @@
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
 let compilation_kind = ref Bsb_helper_depfile_gen.Js
 
-let hash : string ref = ref ""
+let hash : Bsb_helper_arg.string_action = 
+  Set {contents = ""}
+  
 let dev_group = ref false
 let namespace = ref None
 
@@ -33,12 +35,12 @@ let () =
   ~argv:Sys.argv
   ~start:1
   [
-    "-g",  Set dev_group ,
+    "-g",  Bool dev_group ,
     " Set the dev group (default to be 0)"
     ;
-    "-bs-ns",  String (fun s -> namespace := Some s),
+    "-bs-ns",  String (Call (fun s -> namespace := Some s)),
     " Set namespace";
-    "-hash",  Set_string hash,
+    "-hash",  String hash,
     " Set hash(internal)";
   ] (fun ~rev_args -> 
       match rev_args with