enable -warn-as-eror refined control while still catpure warnings output

TODO:
- restore configure as error message
- remove unneed exit code 77 handling in ninja

Author: bobzhang

jscomp/bsb/bsb_templates.ml

@@ -14,14 +14,9 @@ let root = OCamlRes.Res.([
       \    \"dir\" : \"src\",\n\
       \    \"subdirs\" : true\n\
       \  },\n\
-      \  \"package-specs\": {\n\
-      \    \"module\": \"commonjs\",\n\
-      \    \"in-source\": true\n\
-      \  },\n\
-      \  \"suffix\": \".bs.js\",\n\
-      \  \"bs-dependencies\": [\n\
-      \  ],\n\
-      \  \"refmt\": 3\n\
+      \  \"warnings\": {\n\
+      \    \"error\" : \"+101\"\n\
+      \  }\n\
        }\n\
        ") ;
     File  ("package.json",

jscomp/bsb/bsb_warning.ml

@@ -23,10 +23,16 @@
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
 
 
+type warning_error =
+  | Warn_error_false
+  (* default [false] to make our changes non-intrusive *)
+  | Warn_error_true
+  | Warn_error_number of string
 
 type t0 = {
-  number : string option; 
-} [@@ocaml.unboxed]
+  number : string option;
+  error : warning_error
+}
 
 type nonrec t = t0 option 
 
@@ -64,13 +70,27 @@ let to_merlin_string x =
 
 let from_map (m : Ext_json_types.t Map_string.t) =
   let number_opt = Map_string.find_opt m Bsb_build_schemas.number in
-  let number =
-    match number_opt with
-    | Some (Str { str = number}) -> Some number
-    | None -> None
-    | Some x -> Bsb_exception.config_error x "expect a string"
-  in
-  Some {number }
+  let error_opt = Map_string.find_opt m  Bsb_build_schemas.error in
+  match number_opt, error_opt  with
+  | None, None -> None
+  | _, _ ->
+    let error  =
+      match error_opt with
+      | Some (True _) -> Warn_error_true
+      | Some (False _) -> Warn_error_false
+      | Some (Str {str ; })
+        -> Warn_error_number str
+      | Some x -> Bsb_exception.config_error x "expect true/false or string"
+      | None -> Warn_error_false
+      (** To make it less intrusive : warning error has to be enabled*)
+    in
+    let number =
+      match number_opt with
+      | Some (Str { str = number}) -> Some number
+      | None -> None
+      | Some x -> Bsb_exception.config_error x "expect a string"
+    in
+    Some {number; error }
 
 
 let to_bsb_string ~toplevel warning =
@@ -83,6 +103,15 @@ let to_bsb_string ~toplevel warning =
          Ext_string.empty
        | Some x ->
          prepare_warning_concat ~beg:true x  
-      ) 
+      ) ^
+      (
+        match warning.error with
+        | Warn_error_true ->
+          " -warn-error A"
+        | Warn_error_number y ->
+          " -warn-error " ^ y
+        | Warn_error_false ->
+          Ext_string.empty
+      )
   else " -w a" 
   (* TODO: this is the current default behavior *)

jscomp/bsb/templates/basic/bsconfig.json

@@ -4,5 +4,8 @@
   "sources": {
     "dir" : "src",
     "subdirs" : true
+  },
+  "warnings": {
+    "error" : "+101"
   }
 }

jscomp/build_tests/case3/bsconfig.json

@@ -12,5 +12,6 @@
   "suffix": ".bs.js",
   "bs-dependencies": [
   ],
+  "warnings": {"error" : "+101"},
   "refmt": 3
 }

jscomp/build_tests/custom_namespace/bsconfig.json

@@ -13,7 +13,8 @@
   "bsc-flags" : ["-bs-no-version-header"],
   "bs-dependencies": [],
   "warnings": {
-    "number" : "-40+6+7"
+    "number" : "-40+6+7",
+    "error" : true
   },
   "suffix": ".bs.js"
 }

jscomp/build_tests/customize_namespace/bsconfig.json

@@ -14,5 +14,6 @@
       "depa",
       "depb"
   ],
+  "warnings": {"error" : "+101"},
   "refmt": 3
 }

jscomp/build_tests/cycle/bsconfig.json

@@ -12,5 +12,6 @@
   "suffix": ".bs.js",
   "bs-dependencies": [
   ],
+  "warnings": {"error" : "+101"},
   "refmt": 3
 }

jscomp/build_tests/devdeps/bsconfig.json

@@ -18,5 +18,6 @@
   "bs-dependencies": [
   ],
   "bs-dev-dependencies": ["weird"],
+  "warnings": {"error":"+101"},
   "refmt": 3
 }

jscomp/build_tests/devonly/bsconfig.json

@@ -16,5 +16,6 @@
   "suffix": ".bs.js",
   "bs-dependencies": [
   ],
+  "warnings": {"error" : "+101"},
   "refmt": 3
 }

jscomp/build_tests/duplicated_symlinked_packages/a/bsconfig.json

@@ -14,6 +14,7 @@
     "c",
     "z"
   ],
+  "warnings": {"error" : "+101"},
   "namespace": true,
   "refmt": 3
 }