remove unneeded ppx for method call

Author: bobzhang

jscomp/core/lam_convert.ml

@@ -816,22 +816,20 @@ let convert (exports : Set_ident.t) (lam : Lambda.lambda) : Lam.t * Lam_module_i
       Lam.for_ id (convert_aux from_) (convert_aux to_) dir (convert_aux loop)
     | Lassign (id, body) ->
       Lam.assign id (convert_aux body)
-    | Lsend (Public(Some name), _, obj, _, _loc) ->
+    | Lsend (Public(Some name), _, obj, _, loc) ->
       (* Format.fprintf Format.err_formatter "%a@." Printlambda.lambda b ; *)
-        (match convert_aux obj with
-        | Lprim {primitive =  Pjs_unsafe_downgrade _;  args;loc}
-          ->
-              let setter = Ext_string.ends_with name Literals.setter_suffix in 
-              let property = 
-                if setter then   
-                  Lam_methname.translate 
-                    (String.sub name 0
-                       (String.length name - Literals.setter_suffix_len))
-                else Lam_methname.translate  name in 
-              prim ~primitive:(Pjs_unsafe_downgrade {name = property; setter})
-                ~args loc                
-        | _ ->
-          assert false)
+      let obj =  convert_aux obj in 
+      let args = [obj] in 
+      let setter = Ext_string.ends_with name Literals.setter_suffix in 
+      let property = 
+        if setter then   
+          Lam_methname.translate 
+            (String.sub name 0
+               (String.length name - Literals.setter_suffix_len))
+        else Lam_methname.translate  name in 
+      prim ~primitive:(Pjs_unsafe_downgrade {name = property; setter})
+        ~args loc                
+
     | Lsend _ -> assert false  
     | Levent _ ->
       (* disabled by upstream*)

jscomp/ext/literals.ml

@@ -53,7 +53,7 @@ let setter_suffix = "#="
 let setter_suffix_len = String.length setter_suffix
 
 let debugger = "debugger"
-let unsafe_downgrade = "unsafe_downgrade"
+
 let fn_run = "fn_run"
 let method_run = "method_run"
 

jscomp/frontend/ast_util.ml

@@ -29,11 +29,7 @@ type label_exprs = (Longident.t Asttypes.loc * Parsetree.expression) list
 
 let js_property loc obj (name : string) =
   Parsetree.Pexp_send
-    ((Ast_compatible.app1 ~loc
-        (Exp.ident ~loc
-           {loc;
-            txt = Ldot (Ast_literal.Lid.js_oo, Literals.unsafe_downgrade)})
-        obj), 
+    (obj, 
         {loc; txt = name}
         )
 

jscomp/frontend/bs_ast_invariant.ml

@@ -142,12 +142,6 @@ let emit_external_warnings : iterator=
         | Pexp_new _  -> 
           Location.raise_errorf ~loc:a.pexp_loc
             "OCaml style objects are not supported"
-        | Pexp_send (obj, _) ->
-          begin match obj with 
-            | {pexp_desc = Pexp_apply ({pexp_desc = Pexp_ident ({txt = Ldot(_,"unsafe_downgrade")})},_)} -> ()
-            | _ -> Location.raise_errorf ~loc:a.pexp_loc
-                     "OCaml style objects are not supported"
-          end
         | _ -> super.expr self a         
       );
     label_declaration = (fun self lbl ->     

jscomp/main/builtin_cmi_datasets.ml

@@ -24,8 +24,7 @@
 
 [@@@bs.config {flags = [|"-unboxed-types"|]}]
 (**/**)
-external unsafe_downgrade : 'a  -> 'a = "#unsafe_downgrade"
-external unsafe_to_method : 'a -> 'a = "#fn_method"
+external unsafe_to_method : 'a -> 'a =  "#fn_method"
 (**/**)
 module Callback = struct
   type 'a arity1 = {

jscomp/others/js_OO.ml

@@ -5281,7 +5281,7 @@ let setter_suffix = "#="
 let setter_suffix_len = String.length setter_suffix
 
 let debugger = "debugger"
-let unsafe_downgrade = "unsafe_downgrade"
+
 let fn_run = "fn_run"
 let method_run = "method_run"
 

lib/4.06.1/bsb.ml

@@ -1250,7 +1250,7 @@ let setter_suffix = "#="
 let setter_suffix_len = String.length setter_suffix
 
 let debugger = "debugger"
-let unsafe_downgrade = "unsafe_downgrade"
+
 let fn_run = "fn_run"
 let method_run = "method_run"
 

lib/4.06.1/bsb_helper.ml

@@ -6056,7 +6056,7 @@ let setter_suffix = "#="
 let setter_suffix_len = String.length setter_suffix
 
 let debugger = "debugger"
-let unsafe_downgrade = "unsafe_downgrade"
+
 let fn_run = "fn_run"
 let method_run = "method_run"
 

lib/4.06.1/unstable/all_ounit_tests.ml

@@ -10840,7 +10840,7 @@ let setter_suffix = "#="
 let setter_suffix_len = String.length setter_suffix
 
 let debugger = "debugger"
-let unsafe_downgrade = "unsafe_downgrade"
+
 let fn_run = "fn_run"
 let method_run = "method_run"