fix #4426, apply bs.inlne to float too

Author: bobzhang

jscomp/syntax/ast_literal.ml

@@ -134,6 +134,10 @@ let type_int64 =
   Ast_helper.Typ.mk   
     (Ptyp_constr ({ txt = Lident "int64"; loc = Location.none}, []))  
 
+let type_float =     
+  Ast_helper.Typ.mk   
+    (Ptyp_constr ({ txt = Lident "float"; loc = Location.none}, []))  
+
 let type_any ?loc () =
   match loc with
   | None -> No_loc.type_any

jscomp/syntax/ast_literal.mli

@@ -62,6 +62,7 @@ val type_string : core_type_lit
 val type_bool : core_type_lit
 val type_int : core_type_lit 
 val type_int64 : Parsetree.core_type
+val type_float : Parsetree.core_type
 val type_any : core_type_lit
 
 val pat_unit : pattern_lit

jscomp/syntax/bs_builtin_ppx.ml

@@ -259,7 +259,14 @@ let signature_item_mapper (self : mapper) (sigi : Parsetree.signature_item) =
                     value_desc with 
                     pval_prim = External_ffi_types.inline_int64_primitive s;
                     pval_attributes = [];
-                  } }  
+                  } }
+              | Pexp_constant (Pconst_float(s,None)) -> 
+                Bs_ast_invariant.warn_discarded_unused_attributes pval_attributes; 
+                {sigi with psig_desc = Psig_value  {
+                    value_desc with 
+                    pval_prim = External_ffi_types.inline_float_primitive s;
+                    pval_attributes = [];
+                  } }
               | Pexp_construct ({txt = Lident ("true" | "false" as txt)}, None)       
                 -> 
                 Bs_ast_invariant.warn_discarded_unused_attributes pval_attributes;
@@ -338,6 +345,16 @@ let structure_item_mapper (self : mapper) (str : Parsetree.structure_item) =
                pval_attributes = [];
                pval_prim = External_ffi_types.inline_int64_primitive s
              } }             
+        | Pexp_constant(Pconst_float (s, None))
+          ->
+          Bs_ast_invariant.warn_discarded_unused_attributes pvb_attributes; 
+          {str with pstr_desc = Pstr_primitive  {
+               pval_name = pval_name ;
+               pval_type = Ast_literal.type_float; 
+               pval_loc = pvb_loc;
+               pval_attributes = [];
+               pval_prim = External_ffi_types.inline_float_primitive s
+             } }                 
         | Pexp_construct ({txt = Lident ("true" | "false" as txt) },None) -> 
           Bs_ast_invariant.warn_discarded_unused_attributes pvb_attributes; 
           {str with pstr_desc = Pstr_primitive  {

jscomp/syntax/external_ffi_types.ml

@@ -316,6 +316,11 @@ let inline_int64_primitive (i : int64) : string list =
         (Const_int64 i))
   ]
 
+let inline_float_primitive (i : string) : string list =
+  ["";
+    to_string 
+      (Ffi_inline_const (Const_float i))
+  ]    
 let rec ffi_bs_aux acc (params : External_arg_spec.params) = 
   match params with 
   | {arg_type = Nothing; arg_label = Arg_empty} 

jscomp/syntax/external_ffi_types.mli

@@ -141,6 +141,9 @@ val inline_int64_primitive :
   int64 -> 
   string list   
 
+val inline_float_primitive : 
+  string -> string list
+
 val ffi_bs:
   External_arg_spec.params ->
   return_wrapper ->