Merge pull request #4134 from BuckleScript/unused_value_warning_error

unused value warning -> error (for dev)

Author: bobzhang

jscomp/bsb/bsb_config.ml

@@ -57,5 +57,5 @@ let proj_rel path = lazy_src_root_dir // path
 
 
 
-let cmd_package_specs = ref None 
+(* let cmd_package_specs = ref None  *)
 

jscomp/bsb/bsb_config_parse.ml

@@ -23,7 +23,7 @@
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
 
 
-let get_list_string = Bsb_build_util.get_list_string
+(* let get_list_string = Bsb_build_util.get_list_string *)
 let (//) = Ext_path.combine
 let current_package : Bsb_pkg_types.t = Global Bs_version.package_name
 let resolve_package cwd  package_name = 
@@ -39,9 +39,9 @@ let (|?)  m (key, cb) =
   m  |> Ext_json.test key cb
 
 
-
-let extract_main_entries (map :json_map) =  
 #if BS_NATIVE then  
+let extract_main_entries (map :json_map) =  
+
   let extract_entries (field : Ext_json_types.t array) =
     Ext_array.to_list_map (function
         | Ext_json_types.Obj {map} ->
@@ -76,7 +76,7 @@ let extract_main_entries (map :json_map) =
     | _ -> ()
   end; !entries
 #else 
-  []  
+let extract_main_entries (_ :json_map) = []  
 #end
 
 

jscomp/bsb/bsb_db_util.ml

@@ -24,7 +24,7 @@
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
 type module_info = Bsb_db.module_info
 type t = Bsb_db.t
-type case = Bsb_db.case
+(* type case = Bsb_db.case *)
 
 
 

jscomp/bsb/bsb_log.ml

@@ -49,8 +49,8 @@ let color_functions : Format.formatter_tag_functions = {
   print_close_tag = (fun _ -> ())
 }
 
-let set_color ppf =
-  Format.pp_set_formatter_tag_functions ppf color_functions
+(* let set_color ppf =
+  Format.pp_set_formatter_tag_functions ppf color_functions *)
 
 
 let setup () = 

jscomp/bsb/bsb_merlin_gen.ml

@@ -110,7 +110,7 @@ let merlin_file_gen ~per_proj_dir:(per_proj_dir:string)
       external_includes; 
       reason_react_jsx ; 
       namespace;
-      package_name;
+      package_name = _;
       warning; 
      } : Bsb_config_types.t)
   =

jscomp/bsb/bsb_ninja_gen.ml

@@ -31,7 +31,7 @@ let (//) = Ext_path.combine
 
 
 
-let dash_i = "-I"
+(* let dash_i = "-I" *)
 
 
 
@@ -184,8 +184,8 @@ let output_ninja_and_namespace_map
       Bsb_db_util.sanity_check bs_group;
       [|bs_group|], source_dirs, static_resources
     else
-      let bs_groups = Array.init  (number_of_dev_groups + 1 ) (fun i -> Map_string.empty) in
-      let source_dirs = Array.init (number_of_dev_groups + 1 ) (fun i -> []) in
+      let bs_groups = Array.init  (number_of_dev_groups + 1 ) (fun _ -> Map_string.empty) in
+      let source_dirs = Array.init (number_of_dev_groups + 1 ) (fun _ -> []) in
       let static_resources =
         Ext_list.fold_left bs_file_groups [] (fun (acc_resources : string list) {sources; dir; resources; dir_index} 
            ->

jscomp/bsb/bsb_parse_sources.ml

@@ -28,7 +28,7 @@ type build_generator = Bsb_file_groups.build_generator
 
 
 
-type file_group = Bsb_file_groups.file_group
+(* type file_group = Bsb_file_groups.file_group *)
 
 type t = Bsb_file_groups.t 
 
@@ -134,7 +134,7 @@ type json_map = Ext_json_types.t Map_string.t
 
 let extract_generators (input : json_map) : build_generator list  =
   match Map_string.find_opt input  Bsb_build_schemas.generators with
-  | Some (Arr { content ; loc_start}) ->
+  | Some (Arr { content ; loc_start= _}) ->
     (* Need check is dev build or not *)
     Ext_array.fold_left content [] (fun acc x ->
         match x with
@@ -294,7 +294,7 @@ let rec
               Bsb_db_util.add_basename ~dir acc basename ~error_on_invalid_suffix:loc
             | _ -> acc
           ) 
-      | Some (Obj {map = map; loc} ) -> (* { excludes : [], slow_re : "" }*)
+      | Some (Obj {map = map; loc = _} ) -> (* { excludes : [], slow_re : "" }*)
         let predicate = extract_predicate map in 
         Ext_array.fold_left (Lazy.force base_name_array) output_sources (fun acc basename -> 
             if is_input_or_output scanned_generators basename || not (predicate basename) then acc 

jscomp/bsb/bsb_unix.ml

@@ -49,7 +49,7 @@ let run_command_execv_unix  cmd : int =
     Unix.execv cmd.cmd cmd.args 
   | pid -> 
     match Unix.waitpid [] pid  with 
-    | pid, process_status ->       
+    | _, process_status ->       
       match process_status with 
       | Unix.WEXITED eid ->
         eid    

jscomp/bsb/bsb_world.ml

@@ -28,7 +28,7 @@ let (//) = Ext_path.combine
 (** TODO: create the animation effect 
     logging installed files
 *)
-let install_targets cwd ({files_to_install; namespace; package_name} : Bsb_config_types.t ) =  
+let install_targets cwd ({files_to_install; namespace; package_name = _} : Bsb_config_types.t ) =  
   let install ~destdir file = 
      Bsb_file.install_if_exists ~destdir file  |> ignore
   in

jscomp/bsb_helper/bsb_helper_dep_graph.ml

@@ -98,7 +98,7 @@ let get_otherlibs_dependencies dependency_graph file_extension =
     else
       acc
   in
-  let set_of_otherlib_deps = Map_string.fold dependency_graph Set_string.empty (fun k v acc ->
+  let set_of_otherlib_deps = Map_string.fold dependency_graph Set_string.empty (fun _k v acc ->
     let addIfPresent = addIfPresentInSet v in
     acc
       |> addIfPresent "Unix"     "unix"