Merge pull request #4962 from illusionalsagacity/bind-to-number-methods

Bind Js.Float isFinite / isNaN to Number instead of window scope

Author: bobzhang

jscomp/main/builtin_cmi_datasets.ml

@@ -40,7 +40,7 @@ therefore necessary to test for [_NaN].
 
 @see <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isNaN> MDN
 *)
-external isNaN : float -> bool = "isNaN" [@@bs.val]
+external isNaN : float -> bool = "isNaN" [@@bs.val] [@@bs.scope "Number"]
 
 (** Tests if the given value is finite
 
@@ -62,7 +62,7 @@ let _ = Js.Float.isFinite 1234
 
 @see <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isFinite> MDN
 *)
-external isFinite : float -> bool = "isFinite" [@@bs.val]
+external isFinite : float -> bool = "isFinite" [@@bs.val] [@@bs.scope "Number"]
 
 (** Formats a [float] using exponential (scientific) notation
 

jscomp/others/js_float.ml

@@ -163,8 +163,8 @@ Mt_global.collect_eq(test_id, suites, "File \"float_test.ml\", line 48, characte
 var match$3 = Caml_float.caml_modf_float(Number.NaN);
 
 Mt_global.collect_eq(test_id, suites, "File \"float_test.ml\", line 49, characters 5-12", [
-      isNaN(match$3[0]),
-      isNaN(match$3[1])
+      Number.isNaN(match$3[0]),
+      Number.isNaN(match$3[1])
     ], [
       true,
       true

jscomp/test/float_test.js

@@ -45,7 +45,7 @@ var suites_1 = {
         (function (param) {
             return {
                     TAG: /* Ok */4,
-                    _0: isNaN(Date.parse("gibberish"))
+                    _0: Number.isNaN(Date.parse("gibberish"))
                   };
           })
       ],
@@ -77,7 +77,7 @@ var suites_1 = {
               (function (param) {
                   return {
                           TAG: /* Ok */4,
-                          _0: isNaN(new Date("gibberish").getTime())
+                          _0: Number.isNaN(new Date("gibberish").getTime())
                         };
                 })
             ],

jscomp/test/js_date_test.js

@@ -21,7 +21,7 @@ var suites_1 = {
         return {
                 TAG: /* Eq */0,
                 _0: true,
-                _1: isNaN(NaN)
+                _1: Number.isNaN(NaN)
               };
       })
   ],
@@ -32,7 +32,7 @@ var suites_1 = {
           return {
                   TAG: /* Eq */0,
                   _0: false,
-                  _1: isNaN(0)
+                  _1: Number.isNaN(0)
                 };
         })
     ],
@@ -43,7 +43,7 @@ var suites_1 = {
             return {
                     TAG: /* Eq */0,
                     _0: false,
-                    _1: isFinite(Pervasives.infinity)
+                    _1: Number.isFinite(Pervasives.infinity)
                   };
           })
       ],
@@ -54,7 +54,7 @@ var suites_1 = {
               return {
                       TAG: /* Eq */0,
                       _0: false,
-                      _1: isFinite(Pervasives.neg_infinity)
+                      _1: Number.isFinite(Pervasives.neg_infinity)
                     };
             })
         ],
@@ -65,7 +65,7 @@ var suites_1 = {
                 return {
                         TAG: /* Eq */0,
                         _0: false,
-                        _1: isFinite(NaN)
+                        _1: Number.isFinite(NaN)
                       };
               })
           ],
@@ -76,7 +76,7 @@ var suites_1 = {
                   return {
                           TAG: /* Eq */0,
                           _0: true,
-                          _1: isFinite(0)
+                          _1: Number.isFinite(0)
                         };
                 })
             ],
@@ -490,7 +490,7 @@ var suites_1 = {
                                                                                           return {
                                                                                                   TAG: /* Eq */0,
                                                                                                   _0: true,
-                                                                                                  _1: isNaN(Number("foo"))
+                                                                                                  _1: Number.isNaN(Number("foo"))
                                                                                                 };
                                                                                         })
                                                                                     ],