Remove Vite server hooks in child compiler plugins (#13184)

Author: jamesopstad

.changeset/eleven-oranges-cheat.md

@@ -0,0 +1,5 @@
+---
+"@react-router/dev": patch
+---
+
+Fix conflicts with other Vite plugins that use the `configureServer` and/or `configurePreviewServer` hooks

packages/react-router-dev/vite/plugin.ts

@@ -1384,6 +1384,10 @@ export const reactRouterVitePlugin: ReactRouterVitePlugin = () => {
           }
         }
 
+        const childCompilerPlugins = await asyncFlatten(
+          childCompilerConfigFile.config.plugins ?? []
+        );
+
         viteChildCompiler = await vite.createServer({
           ...viteUserConfig,
           // Ensure child compiler cannot overwrite the default cache directory
@@ -1397,8 +1401,7 @@ export const reactRouterVitePlugin: ReactRouterVitePlugin = () => {
           configFile: false,
           envFile: false,
           plugins: [
-            ...(childCompilerConfigFile.config.plugins ?? [])
-              .flat()
+            childCompilerPlugins
               // Exclude this plugin from the child compiler to prevent an
               // infinite loop (plugin creates a child compiler with the same
               // plugin that creates another child compiler, repeat ad
@@ -1407,14 +1410,20 @@ export const reactRouterVitePlugin: ReactRouterVitePlugin = () => {
               // production build because the child compiler is a Vite dev
               // server and will generate incorrect manifests.
               .filter(
-                (plugin) =>
+                (plugin): plugin is Vite.Plugin =>
                   typeof plugin === "object" &&
                   plugin !== null &&
                   "name" in plugin &&
                   plugin.name !== "react-router" &&
                   plugin.name !== "react-router:route-exports" &&
                   plugin.name !== "react-router:hmr-updates"
-              ),
+              )
+              // Remove server hooks to avoid conflicts with main dev server
+              .map((plugin) => ({
+                ...plugin,
+                configureServer: undefined,
+                configurePreviewServer: undefined,
+              })),
             {
               name: "react-router:override-optimize-deps",
               config(userConfig) {
@@ -3509,3 +3518,17 @@ async function getEnvironmentsOptions(
 function isNonNullable<T>(x: T): x is NonNullable<T> {
   return x != null;
 }
+
+// Type and function copied from Vite
+type AsyncFlatten<T extends unknown[]> = T extends (infer U)[]
+  ? Exclude<Awaited<U>, U[]>[]
+  : never;
+
+async function asyncFlatten<T extends unknown[]>(
+  arr: T
+): Promise<AsyncFlatten<T>> {
+  do {
+    arr = (await Promise.all(arr)).flat(Infinity) as any;
+  } while (arr.some((v: any) => v?.then));
+  return arr as unknown[] as AsyncFlatten<T>;
+}