fix: use only in directory routes on +routes RouteModules (#14439)

* Typegen: only register route module types for routes inside the app directory

---------

Co-authored-by: Pedro Cattori <pcattori@gmail.com>

Author: fernandojbf

.changeset/shy-eels-drum.md

@@ -0,0 +1,5 @@
+---
+"@react-router/dev": patch
+---
+
+Typegen: only register route module types for routes within the app directory

contributors.yml

@@ -117,6 +117,7 @@
 - ericschn
 - esadek
 - faergeek
+- fernandojbf
 - FilipJirsak
 - focusotter
 - foxscotch

integration/typegen-test.ts

@@ -456,6 +456,31 @@ test.describe("typegen", () => {
     await $("pnpm typecheck");
   });
 
+  test("route files with paths outside of app directory", async ({
+    cwd,
+    edit,
+    $,
+  }) => {
+    await fs.mkdir(Path.join(cwd, "node_modules/external_dependency"), {
+      recursive: true,
+    });
+    await edit({
+      "app/routes.ts": tsx`
+        import { type RouteConfig, route } from "@react-router/dev/routes";
+
+        export default [
+          route("outside/:id", "../node_modules/external_dependency/index.js"),
+        ] satisfies RouteConfig;
+      `,
+      "node_modules/external_dependency/index.js": tsx`
+        export default function Component() {
+          return <div>External Dependency</div>
+        }
+      `,
+    });
+    await $("pnpm typecheck");
+  });
+
   test("href", async ({ edit, $ }) => {
     await edit({
       "app/routes.ts": tsx`

packages/react-router-dev/typegen/generate.ts

@@ -205,13 +205,15 @@ function routeModulesType(ctx: Context) {
         t.tsPropertySignature(
           t.stringLiteral(route.id),
           t.tsTypeAnnotation(
-            t.tsTypeQuery(
-              t.tsImportType(
-                t.stringLiteral(
-                  `./${Path.relative(ctx.rootDirectory, ctx.config.appDirectory)}/${route.file}`,
-                ),
-              ),
-            ),
+            isInAppDirectory(ctx, route.file)
+              ? t.tsTypeQuery(
+                  t.tsImportType(
+                    t.stringLiteral(
+                      `./${Path.relative(ctx.rootDirectory, ctx.config.appDirectory)}/${route.file}`,
+                    ),
+                  ),
+                )
+              : t.tsUnknownKeyword(),
           ),
         ),
       ),