chore(pm-app): unify error usage (#88)

Author: MichaelDeBoey

pm-app/app/routes/dashboard/projects/$projectId/delete.tsx

@@ -12,8 +12,8 @@ export const action: ActionFunction = async ({ request, params }) => {
   if (projectId) {
     try {
       await deleteProject(projectId);
-    } catch (e) {
-      console.error(e);
+    } catch (error: unknown) {
+      console.error(error);
     }
   }
   return redirect("/dashboard");

pm-app/app/routes/dashboard/todos/$todoId/delete.tsx

@@ -22,7 +22,7 @@ export const action: ActionFunction = async ({ request, params }) => {
     try {
       actionData = { todo: await deleteTodo(todoId) };
       return json(actionData);
-    } catch (e) {
+    } catch {
       actionData = { todo: null };
       return json(actionData, 400);
     }

pm-app/app/routes/dashboard/todos/$todoId/edit.tsx

@@ -50,7 +50,7 @@ export const action: ActionFunction = async ({ request, context, params }) => {
       const todo = await updateTodo(todoId, todoUpdates);
       actionData = { todo };
       return json(actionData, 200);
-    } catch (e) {
+    } catch {
       actionData = { todo: null };
       return json(actionData, 400);
     }

pm-app/app/routes/dashboard/todos/$todoId/index.tsx

@@ -47,8 +47,7 @@ export const action: ActionFunction = async ({ request, context, params }) => {
       });
       actionData = { todo };
       return json(actionData, 200);
-    } catch (e) {
-      // console.error(e);
+    } catch {
       actionData = { todo: null };
       return json(actionData, 400);
     }

pm-app/app/routes/dashboard/todos/$todoId/set.tsx

@@ -27,7 +27,7 @@ export const action: ActionFunction = async ({ request, params }) => {
       });
       actionData = { todo };
       return json(actionData, 200);
-    } catch (e) {
+    } catch {
       actionData = { todo: null };
       return json(actionData, 400);
     }

pm-app/app/routes/dashboard/todos/new.tsx

@@ -50,7 +50,7 @@ export const action: ActionFunction = async ({ request, params }) => {
       const todo = await createTodo(todoData);
       actionData = { todo };
       return json(actionData, 200);
-    } catch (e) {
+    } catch {
       actionData = { todo: null };
       return json(actionData, 400);
     }

pm-app/app/routes/register.tsx

@@ -83,8 +83,8 @@ export const action: ActionFunction = async ({ request }) => {
   } else {
     try {
       validateEmail(email);
-    } catch (e) {
-      fieldErrors.email = (e as Error).message;
+    } catch (error: unknown) {
+      fieldErrors.email = (error as Error).message;
     }
   }
 
@@ -93,8 +93,8 @@ export const action: ActionFunction = async ({ request }) => {
   } else {
     try {
       validatePassword(password);
-    } catch (e) {
-      fieldErrors.password = (e as Error).message;
+    } catch (error: unknown) {
+      fieldErrors.password = (error as Error).message;
     }
   }
 

pm-app/app/routes/sign-in.tsx

@@ -60,11 +60,11 @@ export const action: ActionFunction = async ({ request }) => {
   } else {
     try {
       validateEmail(email);
-    } catch (e) {
-      if (e instanceof Error) {
-        fieldErrors.email = e.message;
-      } else if (typeof e === "string") {
-        fieldErrors.email = e;
+    } catch (error: unknown) {
+      if (error instanceof Error) {
+        fieldErrors.email = error.message;
+      } else if (typeof error === "string") {
+        fieldErrors.email = error;
       } else {
         fieldErrors.email = "There was an error with this field";
       }
@@ -76,11 +76,11 @@ export const action: ActionFunction = async ({ request }) => {
   } else {
     try {
       validatePassword(password);
-    } catch (e) {
-      if (e instanceof Error) {
-        fieldErrors.password = e.message;
-      } else if (typeof e === "string") {
-        fieldErrors.password = e;
+    } catch (error: unknown) {
+      if (error instanceof Error) {
+        fieldErrors.password = error.message;
+      } else if (typeof error === "string") {
+        fieldErrors.password = error;
       } else {
         fieldErrors.password = "There was an error with this field";
       }
@@ -95,12 +95,12 @@ export const action: ActionFunction = async ({ request }) => {
   let user: User | null;
   try {
     user = await login(email, password);
-  } catch (e) {
+  } catch (error: unknown) {
     let formError: string;
-    if (e instanceof Error) {
-      formError = e.message;
-    } else if (typeof e === "string") {
-      formError = e;
+    if (error instanceof Error) {
+      formError = error.message;
+    } else if (typeof error === "string") {
+      formError = error;
     } else {
       formError = "There was an error logging in. Please try again later.";
     }

pm-app/app/utils/index.ts

@@ -35,11 +35,11 @@ export function getClientSafeEnvVariable<
         );
       }
       return ENV[key];
-    } catch (err) {
+    } catch (error) {
       console.error(
         "There was an error parsing window.ENV. See https://remix.run/guides/envvars#browser-environment-variables"
       );
-      throw err;
+      throw error;
     }
   } else {
     return process.env[key];

pm-app/app/utils/sanitizer.ts

@@ -24,7 +24,7 @@ export class Sanitizer {
       if (typeof arg === "number") {
         flo = parseFloat(flo.toFixed(arg));
       }
-    } catch (e) {
+    } catch {
       return null;
     }
     return flo;
@@ -33,7 +33,7 @@ export class Sanitizer {
   static int(value: any) {
     try {
       return parseInt(value);
-    } catch (e) {
+    } catch {
       return null;
     }
   }
@@ -114,7 +114,7 @@ export class Sanitizer {
         return JSON.parse(JSON.stringify(value));
       }
       return null;
-    } catch (e) {
+    } catch {
       return null;
     }
   }