Skip to content

Conversation

@joeizang
Copy link
Collaborator

@joeizang joeizang commented Nov 7, 2025

fixes #6518

@joeizang joeizang requested a review from ryestew November 7, 2025 15:44
@joeizang joeizang self-assigned this Nov 7, 2025
@joeizang joeizang added the ready-to-review PR ready to review label Nov 7, 2025
@netlify
Copy link

netlify bot commented Nov 7, 2025

Deploy Preview for reliable-cocada-166884 ready!

Name Link
🔨 Latest commit 243fdf1
🔍 Latest deploy log https://app.netlify.com/projects/reliable-cocada-166884/deploys/69136a7631a2dd000819ad62
😎 Deploy Preview https://deploy-preview-6520--reliable-cocada-166884.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ryestew
Copy link
Collaborator

ryestew commented Nov 10, 2025

This update has fixed the problem for me.

The logic should be that deployment to all chains are allowed to use the default VM - (now at Prague). If a chain contacts us, we can limit that that chain's EVM maximum fork - but it will be up to them to get back to us to tell us that they have made an update. Although they will likely forget to contact us again to bring them up to date.

for a little history: evmmap.tx was originally done for Celo Mainnet which was not up to the latest EVM. So we limited it. They have been up to date for some time now.

@ryestew ryestew requested review from yann300 and removed request for ryestew November 10, 2025 03:48
@yann300
Copy link
Contributor

yann300 commented Nov 10, 2025

why did you comment out everything?

@Aniket-Engg Aniket-Engg requested a review from ryestew November 10, 2025 10:18
@ryestew
Copy link
Collaborator

ryestew commented Nov 10, 2025

@joeizang - can you respond to Yann? The reason is because when a chain is listed it limits that chain to the specified EVM. But we need to remove all the limitations and only add them when the chain contacts us. Probably for merging the commented lines can be removed - unless there is a reason to keep them commented out. Also Mainnet could be removed from all of the EVMs because it will be always up to date with the latest (by definition).

@nx-cloud
Copy link

nx-cloud bot commented Nov 10, 2025

View your CI Pipeline Execution ↗ for commit 243fdf1

Command Status Duration Result
nx lint vyper ✅ Succeeded <1s View ↗
nx lint remixd ✅ Succeeded <1s View ↗
nx lint solhint ✅ Succeeded <1s View ↗
nx lint doc-gen ✅ Succeeded <1s View ↗
nx lint remix-ui ✅ Succeeded 11s View ↗
nx lint learneth ✅ Succeeded <1s View ↗
nx lint debugger ✅ Succeeded <1s View ↗
nx lint remix-lib ✅ Succeeded <1s View ↗
Additional runs (23) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-11-12 07:57:46 UTC

@ci-pr-comment
Copy link

ci-pr-comment bot commented Nov 10, 2025

❌ E2E failures detected (workflow: web)

Last run: Wed, Nov 12, 2025, 08:06 AM UTC

View HTML report

Top failing tests (1/1):

  • Compile test contract and deploy to remix VM (vyper_api_group1.test)

Report generated by CI; artifacts are retained per CircleCI retention settings.

@Aniket-Engg Aniket-Engg merged commit 637a219 into master Nov 12, 2025
34 checks passed
@Aniket-Engg Aniket-Engg deleted the joe-patch-015 branch November 12, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-review PR ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Celo chain is compatible with Prague but doesn't let me deploy it.

5 participants