Skip to content

Commit ec22db2

Browse files
ekoutsvkarak
authored andcommitted
Log results for all tests, not only perf tests
1 parent 45f866c commit ec22db2

File tree

3 files changed

+7
-22
lines changed

3 files changed

+7
-22
lines changed

reframe/core/logging.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -933,14 +933,10 @@ def _update_check_extras(self):
933933
self.extra['check_job_completion_time_unix'], r'%FT%T%:z'
934934
)
935935

936-
def log_performance(
937-
self, level, task, msg=None, multiline=False, log_sanity=False
936+
def log_result(
937+
self, level, task, msg=None, multiline=False
938938
):
939-
if (
940-
self.check is None or
941-
not self.check.is_performance_check() and
942-
not log_sanity
943-
):
939+
if self.check is None:
944940
return
945941

946942
_, part, env = task.testcase

reframe/frontend/executors/__init__.py

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -235,9 +235,6 @@ def __init__(self, case, listeners=None, timeout=None):
235235
self._perflog_compat = runtime.runtime().get_option(
236236
'logging/0/perflog_compat'
237237
)
238-
self._log_sanity_results = runtime.runtime().get_option(
239-
'logging/0/log_sanity_results'
240-
)
241238

242239
def duration(self, phase):
243240
# Treat pseudo-phases first
@@ -528,11 +525,8 @@ def finalize(self):
528525
self._current_stage = 'finalize'
529526
self._notify_listeners('on_task_success')
530527
try:
531-
self._perflogger.log_performance(
532-
logging.INFO, self,
533-
multiline=self._perflog_compat,
534-
log_sanity=self._log_sanity_results
535-
)
528+
self._perflogger.log_result(logging.INFO, self,
529+
multiline=self._perflog_compat)
536530
except LoggingError as e:
537531
getlogger().warning(
538532
f'could not log performance data for {self.testcase}: {e}'
@@ -556,11 +550,8 @@ def _wait_job(job):
556550
self._exc_info = exc_info or sys.exc_info()
557551
self._notify_listeners(callback)
558552
try:
559-
self._perflogger.log_performance(
560-
logging.INFO, self,
561-
multiline=self._perflog_compat,
562-
log_sanity=self._log_sanity_results
563-
)
553+
self._perflogger.log_result(logging.INFO, self,
554+
multiline=self._perflog_compat)
564555
except LoggingError as e:
565556
getlogger().warning(
566557
f'could not log performance data for {self.testcase}: {e}'

reframe/schemas/config.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,6 @@
440440
"properties": {
441441
"level": {"$ref": "#/defs/loglevel"},
442442
"perflog_compat": {"type": "boolean"},
443-
"log_sanity_results": {"type": "boolean"},
444443
"handlers": {
445444
"type": "array",
446445
"items": {
@@ -622,7 +621,6 @@
622621
"general/verbose": 0,
623622
"logging/level": "undefined",
624623
"logging/perflog_compat": false,
625-
"logging/log_sanity_results": false,
626624
"logging/target_systems": ["*"],
627625
"logging/handlers": [],
628626
"logging/handlers_perflog": [],

0 commit comments

Comments
 (0)