Skip to content

Commit cfcffa3

Browse files
ekoutsvkarak
authored andcommitted
Refactor log performance function
1 parent 94cf560 commit cfcffa3

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

reframe/core/logging.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -933,11 +933,13 @@ def _update_check_extras(self):
933933
self.extra['check_job_completion_time_unix'], r'%FT%T%:z'
934934
)
935935

936-
def log_performance(self, level, task, msg=None, multiline=False):
936+
def log_performance(
937+
self, level, task, msg=None, multiline=False, log_sanity=False
938+
):
937939
if (
938940
self.check is None or
939941
not self.check.is_performance_check() and
940-
not getattr(self.logger, '_log_sanity_results', False)
942+
not log_sanity
941943
):
942944
return
943945

reframe/frontend/executors/__init__.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -528,8 +528,11 @@ def finalize(self):
528528
self._current_stage = 'finalize'
529529
self._notify_listeners('on_task_success')
530530
try:
531-
self._perflogger.log_performance(logging.INFO, self,
532-
multiline=self._perflog_compat)
531+
self._perflogger.log_performance(
532+
logging.INFO, self,
533+
multiline=self._perflog_compat,
534+
log_sanity=self._log_sanity_results
535+
)
533536
except LoggingError as e:
534537
getlogger().warning(
535538
f'could not log performance data for {self.testcase}: {e}'
@@ -553,8 +556,11 @@ def _wait_job(job):
553556
self._exc_info = exc_info or sys.exc_info()
554557
self._notify_listeners(callback)
555558
try:
556-
self._perflogger.log_performance(logging.INFO, self,
557-
multiline=self._perflog_compat)
559+
self._perflogger.log_performance(
560+
logging.INFO, self,
561+
multiline=self._perflog_compat,
562+
log_sanity=self._log_sanity_results
563+
)
558564
except LoggingError as e:
559565
getlogger().warning(
560566
f'could not log performance data for {self.testcase}: {e}'

0 commit comments

Comments
 (0)