Merge pull request #3247 from vkarak/bugfix/none-perf-crash

[bugfix] Ignore records with unset performance when grouping test cases

Author: vkarak

reframe/frontend/cli.py

@@ -1662,8 +1662,8 @@ def module_unuse(*paths):
             printer.error(message)
 
         if errors.is_exit_request(*exc_info):
-            # Print stack traces for exit requests only when TOO verbose
-            printer.debug2(tb)
+            # Print stack traces for exit requests when debugging
+            printer.debug(tb)
         elif errors.is_severe(*exc_info):
             printer.error(tb)
         else:

reframe/frontend/reporting/__init__.py

@@ -511,6 +511,11 @@ def _group_testcases(testcases, group_by, extra_cols):
         for pvar, reftuple in tc['perfvalues'].items():
             pvar = pvar.split(':')[-1]
             pval, pref, plower, pupper, punit = reftuple
+            if pval is None:
+                # Ignore `None` performance values
+                # (performance tests that failed sanity)
+                continue
+
             plower = pref * (1 + plower) if plower is not None else -math.inf
             pupper = pref * (1 + pupper) if pupper is not None else math.inf
             record = {

unittests/resources/checks/frontend_checks.py

@@ -63,10 +63,15 @@ class NoPrgEnvCheck(BaseFrontendCheck):
 
 @rfm.simple_test
 class SanityFailureCheck(BaseFrontendCheck):
+    '''A performance test that fails in sanity.'''
     @sanity_function
     def validate_output(self):
         return sn.assert_found('foo', self.stdout)
 
+    @performance_function('Gflop/s')
+    def perf(self):
+        return sn.extractsingle(r'perf: (\d+)', self.stdout, 1, int)
+
 
 @rfm.simple_test
 class PerformanceFailureCheck(BaseFrontendCheck):