Skip to content

Commit 46e7166

Browse files
authored
Merge pull request #3287 from vkarak/packaging/ship-getpip
[packaging] Use local copies of `get-pip.py` for bootstrapping
2 parents 90d6980 + 35ce578 commit 46e7166

File tree

11 files changed

+88559
-23
lines changed

11 files changed

+88559
-23
lines changed

.github/workflows/test-flux.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ jobs:
2828

2929
- name: Install Reframe
3030
run: |
31-
apt-get update && apt-get install -y python3-pip curl
32-
/bin/bash ./bootstrap.sh
31+
apt-get update && apt-get install -y python3-pip
32+
./bootstrap.sh
3333
export PATH=$PWD/bin:$PATH
3434
which reframe
3535

.github/workflows/test-schedulers.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@ jobs:
1919
- name: Build Images
2020
run: |
2121
docker compose -f .github/pseudo-cluster/docker-compose.yml build
22-
- name: Run Unittests with ${{ matrix.scheduler }} sceduler
22+
- name: Run Unittests with ${{ matrix.scheduler }} scheduler
2323
run: |
2424
BACKEND=${{ matrix.scheduler }} docker compose -f .github/pseudo-cluster/docker-compose.yml up --abort-on-container-exit --exit-code-from frontend

bootstrap.sh

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -101,23 +101,16 @@ py_pkg_prefix=external/$(uname -m)
101101
# Install a fresh pip in the current environment
102102
pyver=$(python3 -c 'import sys; print(".".join(str(s) for s in sys.version_info[:2]))')
103103
if [ "$pyver" == "3.6" ]; then
104-
get_pip_url="https://bootstrap.pypa.io/pip/3.6/get-pip.py"
104+
get_pip="$PWD/tools/python/3.6/get-pip.py"
105105
elif [ "$pyver" == "3.7" ]; then
106-
get_pip_url="https://bootstrap.pypa.io/pip/3.7/get-pip.py"
106+
get_pip="$PWD/tools/python/3.7/get-pip.py"
107107
else
108-
get_pip_url="https://bootstrap.pypa.io/get-pip.py"
108+
get_pip="$PWD/tools/python/get-pip.py"
109109
fi
110110

111-
if ! type "curl" > /dev/null 2>&1; then
112-
echo -e "could not find \`curl': please install curl and try again"
113-
exit 1
114-
fi
115-
116-
INFO "curl -s $get_pip_url | $python"
117-
curl -s $get_pip_url | $python
118-
119-
export PATH=$(pwd)/$py_pkg_prefix/usr/bin:$PATH
120-
export PYTHONPATH=$(pwd)/$py_pkg_prefix:$PYTHONPATH
111+
$python $get_pip
112+
export PATH=$PWD/$py_pkg_prefix/usr/bin:$PATH
113+
export PYTHONPATH=$PWD/$py_pkg_prefix:$PYTHONPATH
121114
if [ -n "$PYGELF" ]; then
122115
tmp_requirements=$(mktemp)
123116
sed -e 's/^#+pygelf%//g' requirements.txt > $tmp_requirements

ci-scripts/dockerfiles/eb-spack-howto.dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55

66
FROM ghcr.io/reframe-hpc/lmod:8.4.12
77

8-
ENV _SPACK_VER=0.16
9-
ENV _EB_VER=4.4.1
8+
ENV _SPACK_VER=0.22.2
9+
ENV _EB_VER=4.9.4
1010

1111

1212
# Install ReFrame unit test requirements
@@ -19,7 +19,7 @@ RUN useradd -ms /bin/bash rfmuser
1919
USER rfmuser
2020

2121
# Install Spack
22-
RUN git clone --branch releases/v${_SPACK_VER} https://github.com/spack/spack ~/spack && \
22+
RUN git clone --branch v${_SPACK_VER} https://github.com/spack/spack ~/spack && \
2323
cd ~/spack
2424

2525
RUN pip3 install easybuild==${_EB_VER}

ci-scripts/dockerfiles/reframe-lmod.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ FROM ghcr.io/reframe-hpc/lmod:8.4.12
77

88
# Install ReFrame unit test requirements
99
RUN apt-get -y update && \
10-
apt-get -y install gcc git make python3 python3-pip curl
10+
apt-get -y install gcc git make python3 python3-pip
1111

1212
# ReFrame user
1313
RUN useradd -ms /bin/bash rfmuser

ci-scripts/dockerfiles/reframe-lmod77.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ FROM ghcr.io/reframe-hpc/lmod:7.7
77

88
# Install ReFrame unit test requirements
99
RUN apt-get -y update && \
10-
apt-get -y install gcc make python3 python3-pip curl
10+
apt-get -y install gcc make python3 python3-pip
1111

1212
# ReFrame user
1313
RUN useradd -ms /bin/bash rfmuser

ci-scripts/dockerfiles/reframe-tmod4.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ FROM ghcr.io/reframe-hpc/tmod:4.6.0
88
# ReFrame requirements
99
RUN \
1010
apt-get -y update && \
11-
apt-get -y install gcc make git python3 python3-pip curl
11+
apt-get -y install gcc make git python3 python3-pip
1212

1313
# ReFrame user
1414
RUN useradd -ms /bin/bash rfmuser

reframe/frontend/autodetect.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ def __enter__(self):
4747
self._workdir = os.path.abspath(
4848
tempfile.mkdtemp(prefix='rfm.', dir=self._prefix)
4949
)
50-
paths = ['bin/', 'reframe/', 'bootstrap.sh', 'requirements.txt']
50+
paths = ['bin/', 'reframe/', 'tools/',
51+
'bootstrap.sh', 'requirements.txt']
5152
use_pip = False
5253
try:
5354
for p in paths:

tools/python/3.6/get-pip.py

Lines changed: 27079 additions & 0 deletions
Large diffs are not rendered by default.

tools/python/3.7/get-pip.py

Lines changed: 33038 additions & 0 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)