Fix coaching relationship sync when navigating between sessions #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sessions When navigating between sessions with different relationships, the page displayed wrong coachee names while showing correct notes. Fixed by: - Updated auto-sync to trigger when relationship ID differs (not just when empty) - Added shouldSyncRelationship helper for readability - Call refresh() after setting new relationship ID to fetch correct data - Added comprehensive test coverage for all sync scenarios Fixes #228
- Extract shouldSyncRelationship to separate module with unit tests - Add explicit return type interfaces for hooks - Create type-safe test factory for CoachingSession (removes 'as any') - Add const assertions to test mock parameters for immutability - Rename coaching_relationship.ts to coaching-relationship.ts for consistency - Update all imports to use hyphenated naming convention - Fix type signatures to allow null coaching relationship IDs - Add 9 comprehensive unit tests for shouldSyncRelationship helper These changes improve type safety, maintainability, and follow TypeScript best practices without changing functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the bug where navigating between coaching sessions with different relationships (e.g. from Today's Sessions) displays the wrong coachee name in the session title while showing the correct notes.
GitHub Issue: Fixes #228
Changes
shouldSyncRelationshiphelper function for improved readability and maintainabilityrefresh()call after setting new relationship ID to force immediate fetch of correct relationship dataTesting Strategy
Automated:
Manual verification needed:
Concerns
None - the fix aligns with the codebase's URL-first architecture and preserves all existing functionality.