Address all Clippy warnings for: "redundant field names in struct initialization."

Author: jhodapp

esp32-wroom-rp/src/lib.rs

@@ -141,16 +141,16 @@ impl FirmwareVersion {
 
     // Takes in 8 bytes (e.g. 1.7.4) and returns a FirmwareVersion instance
     fn parse(version: [u8; ARRAY_LENGTH_PLACEHOLDER]) -> FirmwareVersion {
-        let major: u8;
-        let minor: u8;
-        let patch: u8;
+        let major_version: u8;
+        let minor_version: u8;
+        let patch_version: u8;
 
-        [major, _, minor, _, patch, _, _, _] = version;
+        [major_version, _, minor_version, _, patch_version, _, _, _] = version;
 
         FirmwareVersion {
-            major: major,
-            minor: minor,
-            patch: patch,
+            major: major_version,
+            minor: minor_version,
+            patch: patch_version,
         }
     }
 }

esp32-wroom-rp/src/protocol/operation.rs

@@ -17,12 +17,12 @@ impl<P> Operation<P> {
     // Initializes new Operation instance.
     //
     // `has_params` defaults to `true`
-    pub fn new(command: NinaCommand, number_of_params_to_receive: u8) -> Self {
+    pub fn new(nina_command: NinaCommand, number_of_nina_params_to_receive: u8) -> Self {
         Self {
             params: Vec::new(),
-            command: command,
+            command: nina_command,
             has_params: true,
-            number_of_params_to_receive: number_of_params_to_receive,
+            number_of_params_to_receive: number_of_nina_params_to_receive,
         }
     }
 

esp32-wroom-rp/src/spi.rs

@@ -44,14 +44,14 @@ where
     /// Calling this function puts the connected ESP32-WROOM device in a known good state to accept commands.
     pub fn init<D: DelayMs<u16>>(
         spi: &'a mut S,
-        control_pins: &'a mut C,
+        esp32_control_pins: &'a mut C,
         delay: &mut D,
     ) -> Result<Wifi<'a, S, C>, Error> {
         let mut wifi = Wifi {
             common: WifiCommon {
                 protocol_handler: NinaProtocolHandler {
                     bus: spi,
-                    control_pins: control_pins,
+                    control_pins: esp32_control_pins,
                 },
             },
         };