Skip to content

Commit 1b8ed92

Browse files
Fix tests
1 parent 863425f commit 1b8ed92

File tree

2 files changed

+22
-27
lines changed

2 files changed

+22
-27
lines changed

src/lib.rs

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,12 +83,32 @@ pub fn run(cli: &Cli) -> Result<(), PostSchedulerError> {
8383

8484
#[cfg(test)]
8585
mod tests {
86-
use clap::CommandFactory;
86+
use clap::{error::ErrorKind, CommandFactory, Parser};
8787

88-
use crate::Cli;
88+
use crate::{sensor_posts::MAX_NUM_THREADS, Cli};
8989

9090
#[test]
9191
fn verify_cli() {
9292
Cli::command().debug_assert();
9393
}
94+
95+
#[test]
96+
// #[should_panic]
97+
fn test_invalid_num_threads_low() {
98+
let cli = Cli::try_parse_from(vec!["", "-p", "0"]);
99+
assert!(cli.is_err());
100+
101+
let cli_err = cli.unwrap_err();
102+
assert_eq!(cli_err.kind(), ErrorKind::ValueValidation);
103+
}
104+
105+
#[test]
106+
fn test_invalid_num_threads_high() {
107+
let num = MAX_NUM_THREADS + 1;
108+
let cli = Cli::try_parse_from(vec!["", "-p", &num.to_string()]);
109+
assert!(cli.is_err());
110+
111+
let cli_err = cli.unwrap_err();
112+
assert_eq!(cli_err.kind(), ErrorKind::ValueValidation);
113+
}
94114
}

src/sensor_posts.rs

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -208,28 +208,3 @@ fn generate_random_reading(rng: &mut ThreadRng) -> String {
208208

209209
serde_json::to_string(&reading).unwrap()
210210
}
211-
212-
#[cfg(test)]
213-
mod tests {
214-
use super::{PostSchedulerBuilder, MAX_NUM_THREADS};
215-
216-
// TODO: Add some tests for the parameter logic.
217-
218-
#[test]
219-
fn test_invalid_num_threads_low() {
220-
let req_scheduler = PostSchedulerBuilder::default()
221-
.with_some_num_threads(&Some(0))
222-
.build();
223-
224-
assert!(req_scheduler.is_err())
225-
}
226-
227-
#[test]
228-
fn test_invalid_num_threads_high() {
229-
let req_scheduler = PostSchedulerBuilder::default()
230-
.with_some_num_threads(&Some(MAX_NUM_THREADS + 1))
231-
.build();
232-
233-
assert!(req_scheduler.is_err())
234-
}
235-
}

0 commit comments

Comments
 (0)