Redux-kotlin-threadsafe update

Author: mpetuska

.editorconfig

@@ -3,3 +3,4 @@ root = true
 [*.{kt,kts}]
 indent_size = 2
 ignored_rules = no-wildstar-imports
+insert_final_newline = true

CHANGELOG.md

@@ -10,6 +10,7 @@
 
 - Major gradle infra rework
 - Enabled `explicitPublicApi()`
+- BREAKING: `redux-kotlin-threadsafe` APIs moved to a new package: `org.reduxkotlin.threadsafe`
 
 ### Removed
 

build-conventions/build.gradle.kts

@@ -20,6 +20,7 @@ dependencies {
   implementation("io.gitlab.arturbosch.detekt:detekt-gradle-plugin:_")
   implementation("io.github.gradle-nexus:publish-plugin:_")
   implementation("org.jetbrains.dokka:dokka-gradle-plugin:_")
+  implementation("org.jetbrains.kotlinx:atomicfu-gradle-plugin:_")
 }
 
 tasks {

build-conventions/src/main/kotlin/convention.atomicfu.gradle.kts

@@ -0,0 +1,3 @@
+plugins {
+  id("kotlinx-atomicfu")
+}

build-conventions/src/main/kotlin/convention.library-mpp-all.gradle.kts

@@ -0,0 +1,4 @@
+plugins {
+  id("convention.mpp-all")
+  id("convention.library-mpp-loved")
+}

build-conventions/src/main/kotlin/convention.library-mpp.gradle.kts renamed to build-conventions/src/main/kotlin/convention.library-mpp-loved.gradle.kts

@@ -1,7 +1,7 @@
 import util.jvmCommonTest
 
 plugins {
-  id("convention.mpp")
+  id("convention.mpp-loved")
   id("convention.library-android")
   id("convention.control")
 }

build-conventions/src/main/kotlin/convention.mpp-all.gradle.kts

@@ -0,0 +1,40 @@
+import util.targetGroup
+
+plugins {
+  id("convention.mpp-loved")
+}
+
+kotlin {
+  val nativeMain by sourceSets.getting
+  val nativeTest by sourceSets.getting
+  targetGroup(
+    name = "androidNative",
+    mainSourceSetTarget = nativeMain,
+    testSourceSetTarget = nativeTest,
+    androidNativeArm32(),
+    androidNativeArm64(),
+    androidNativeX64(),
+    androidNativeX86(),
+  )
+  targetGroup(
+    name = "mingw",
+    mainSourceSetTarget = nativeMain,
+    testSourceSetTarget = nativeTest,
+    mingwX86(),
+  )
+  targetGroup(
+    name = "linux",
+    mainSourceSetTarget = nativeMain,
+    testSourceSetTarget = nativeTest,
+    linuxArm32Hfp(),
+    linuxArm64(),
+    linuxMips32(),
+    linuxMipsel32(),
+  )
+  targetGroup(
+    name = "watchos",
+    mainSourceSetTarget = "appleMain",
+    testSourceSetTarget = "appleTest",
+    watchosDeviceArm64(),
+  )
+}

build-conventions/src/main/kotlin/convention.mpp.gradle.kts renamed to build-conventions/src/main/kotlin/convention.mpp-loved.gradle.kts

@@ -23,15 +23,6 @@ kotlin {
     mainSourceSetTarget = "commonMain",
     testSourceSetTarget = "commonTest",
   )
-  targetGroup(
-    name = "androidNative",
-    mainSourceSetTarget = nativeMain,
-    testSourceSetTarget = nativeTest,
-    androidNativeArm32(),
-    androidNativeArm64(),
-    androidNativeX64(),
-    androidNativeX86(),
-  )
   val (appleMain, appleTest) = targetGroup<KotlinNativeTarget>(
     name = "apple",
     mainSourceSetTarget = nativeMain,
@@ -60,7 +51,6 @@ kotlin {
     testSourceSetTarget = appleTest,
     watchosArm32(),
     watchosArm64(),
-    watchosDeviceArm64(),
     watchosX64(),
     watchosX86(),
     watchosSimulatorArm64()
@@ -77,16 +67,11 @@ kotlin {
     mainSourceSetTarget = nativeMain,
     testSourceSetTarget = nativeTest,
     mingwX64(),
-    mingwX86(),
   )
   targetGroup(
     name = "linux",
     mainSourceSetTarget = nativeMain,
     testSourceSetTarget = nativeTest,
-    linuxArm32Hfp(),
-    linuxArm64(),
-    linuxMips32(),
-    linuxMipsel32(),
     linuxX64(),
   )
 }

build-conventions/src/main/kotlin/util/targetGroup.kt

@@ -15,8 +15,8 @@ fun <T : KotlinTarget> KotlinMultiplatformExtension.targetGroup(
 ): Pair<KotlinSourceSet, KotlinSourceSet> {
   val mainName = "${name}Main"
   val testName = "${name}Test"
-  val main = sourceSets.create(mainName) { dependsOn(mainSourceSetTarget) }
-  val test = sourceSets.create(testName) { dependsOn(testSourceSetTarget) }
+  val main = sourceSets.maybeCreate(mainName).apply { dependsOn(mainSourceSetTarget) }
+  val test = sourceSets.maybeCreate(testName).apply { dependsOn(testSourceSetTarget) }
   targets.forEach { target ->
     target.compilations["main"].defaultSourceSet { dependsOn(main) }
     target.compilations["test"].defaultSourceSet { dependsOn(test) }

gradle/detekt.yml

@@ -8,19 +8,26 @@ comments:
   active: true
   CommentOverPrivateFunction:
     active: false
+    excludes: [ "**/*Test.kt" ]
   CommentOverPrivateProperty:
     active: false
+    excludes: [ "**/*Test.kt" ]
   DeprecatedBlockTag:
     active: true
+    excludes: [ "**/*Test.kt" ]
   OutdatedDocumentation:
-    active: false
+    active: true
+    excludes: [ "**/*Test.kt" ]
     allowParamOnConstructorProperties: false
-#  UndocumentedPublicClass:
-#    active: true
-#  UndocumentedPublicFunction:
-#    active: true
-#  UndocumentedPublicProperty:
-#    active: true
+  UndocumentedPublicClass:
+    active: true
+    excludes: [ "**/*Test.kt" ]
+  UndocumentedPublicFunction:
+    active: true
+    excludes: [ "**/*Test.kt" ]
+  UndocumentedPublicProperty:
+    active: true
+    excludes: [ "**/*Test.kt" ]
 
 naming:
   InvalidPackageDeclaration:
@@ -49,3 +56,5 @@ formatting:
     active: false
   Indentation:
     indentSize: 2
+  FinalNewline:
+    active: true