Fix lint problems and enable linting on CI

Author: thorn0

packages/toolkit/package.json

@@ -77,13 +77,13 @@
     "yargs": "^15.3.1"
   },
   "scripts": {
-    "build-ci": "yarn rimraf dist && yarn tsc && node scripts/cli.js --skipExtraction",
+    "build-ci": "yarn rimraf dist && yarn tsc && yarn lint && node scripts/cli.js --skipExtraction",
     "build-prepare": "npm run build-ci",
     "build": "yarn rimraf dist && yarn tsc && node scripts/cli.js --local --skipExtraction",
     "build-only": "yarn rimraf dist && yarn tsc && node scripts/cli.js --skipExtraction",
     "format": "prettier --write \"(src|examples)/**/*.{ts,tsx}\" \"**/*.md\"",
     "format:check": "prettier --list-different \"(src|examples)/**/*.{ts,tsx}\" \"docs/*/**.md\"",
-    "lint": "eslint src examples",
+    "lint": "eslint src",
     "test": "jest --runInBand",
     "type-tests": "yarn tsc -p src/tests/tsconfig.typetests.json && yarn tsc -p src/query/tests/tsconfig.typetests.json",
     "prepack": "npm run build-prepare"

packages/toolkit/src/listenerMiddleware/index.ts

@@ -225,6 +225,14 @@ export const createListenerEntry: TypedCreateListenerEntry<unknown> = (
   return entry
 }
 
+const cancelActiveListeners = (
+  entry: ListenerEntry<unknown, Dispatch<AnyAction>>
+) => {
+  entry.pending.forEach((controller) => {
+    abortControllerWithReason(controller, listenerCancelled)
+  })
+}
+
 const createClearListenerMiddleware = (
   listenerMap: Map<string, ListenerEntry>
 ) => {
@@ -281,14 +289,6 @@ const defaultErrorHandler: ListenerErrorHandler = (...args: unknown[]) => {
   console.error(`${alm}/error`, ...args)
 }
 
-const cancelActiveListeners = (
-  entry: ListenerEntry<unknown, Dispatch<AnyAction>>
-) => {
-  entry.pending.forEach((controller) => {
-    abortControllerWithReason(controller, listenerCancelled)
-  })
-}
-
 /**
  * @public
  */

packages/toolkit/src/query/core/buildMiddleware/batchActions.ts

@@ -6,7 +6,8 @@ import type {
   Subscribers,
 } from '../apiState'
 import { produceWithPatches } from 'immer'
-import { createSlice, PayloadAction, AnyAction } from '@reduxjs/toolkit'
+import type { AnyAction } from '@reduxjs/toolkit';
+import { createSlice, PayloadAction } from '@reduxjs/toolkit'
 
 // Copied from https://github.com/feross/queue-microtask
 let promise: Promise<any>

packages/toolkit/src/query/core/buildThunks.ts

@@ -12,15 +12,16 @@ import type {
   QueryActionCreatorResult,
 } from './buildInitiate'
 import { forceQueryFnSymbol, isUpsertQuery } from './buildInitiate'
-import {
+import type {
   AssertTagTypes,
   EndpointDefinition,
   EndpointDefinitions,
-  isQueryDefinition,
   MutationDefinition,
   QueryArgFrom,
   QueryDefinition,
-  ResultTypeFrom,
+  ResultTypeFrom} from '../endpointDefinitions';
+import {
+  isQueryDefinition
 } from '../endpointDefinitions'
 import { calculateProvidedBy } from '../endpointDefinitions'
 import type { AsyncThunkPayloadCreator, Draft } from '@reduxjs/toolkit'

packages/toolkit/src/query/createApi.ts

@@ -1,9 +1,10 @@
 import type { Api, ApiContext, Module, ModuleName } from './apiTypes'
 import type { CombinedState } from './core/apiState'
 import type { BaseQueryArg, BaseQueryFn } from './baseQueryTypes'
+import type {
+  SerializeQueryArgs} from './defaultSerializeQueryArgs';
 import {
-  defaultSerializeQueryArgs,
-  SerializeQueryArgs,
+  defaultSerializeQueryArgs
 } from './defaultSerializeQueryArgs'
 import type {
   EndpointBuilder,

packages/toolkit/src/query/endpointDefinitions.ts

@@ -1,5 +1,5 @@
 import type { AnyAction, ThunkDispatch } from '@reduxjs/toolkit'
-import { SerializeQueryArgs } from './defaultSerializeQueryArgs'
+import type { SerializeQueryArgs } from './defaultSerializeQueryArgs'
 import type { QuerySubState, RootState } from './core/apiState'
 import type {
   BaseQueryExtraOptions,

packages/toolkit/src/query/react/ApiProvider.tsx

@@ -1,5 +1,6 @@
 import { configureStore } from '@reduxjs/toolkit'
-import { Context, useEffect } from 'react'
+import type { Context } from 'react'
+import { useEffect } from 'react'
 import React from 'react'
 import type { ReactReduxContextValue } from 'react-redux'
 import { Provider } from 'react-redux'
@@ -50,7 +51,7 @@ export function ApiProvider<A extends Api<any, {}, any, any>>(props: {
       props.setupListeners === false
         ? undefined
         : setupListeners(store.dispatch, props.setupListeners),
-    [props.setupListeners]
+    [props.setupListeners, store.dispatch]
   )
 
   return (

packages/toolkit/src/query/retry.ts

@@ -5,7 +5,7 @@ import type {
   BaseQueryExtraOptions,
   BaseQueryFn,
 } from './baseQueryTypes'
-import { FetchBaseQueryError } from './fetchBaseQuery'
+import type { FetchBaseQueryError } from './fetchBaseQuery'
 import { HandledError } from './HandledError'
 
 /**

packages/toolkit/src/query/tests/buildHooks.test.tsx

@@ -25,9 +25,10 @@ import {
 import { server } from './mocks/server'
 import type { AnyAction } from 'redux'
 import type { SubscriptionOptions } from '@reduxjs/toolkit/dist/query/core/apiState'
+import type {
+  SerializedError} from '@reduxjs/toolkit';
 import {
   createListenerMiddleware,
-  SerializedError,
   configureStore,
 } from '@reduxjs/toolkit'
 import { renderHook } from '@testing-library/react'

packages/toolkit/src/query/tests/createApi.test.ts

@@ -17,7 +17,7 @@ import {
 } from './helpers'
 import { server } from './mocks/server'
 import { rest } from 'msw'
-import { SerializeQueryArgs } from '../defaultSerializeQueryArgs'
+import type { SerializeQueryArgs } from '../defaultSerializeQueryArgs'
 import { string } from 'yargs'
 
 const originalEnv = process.env.NODE_ENV