remove replacer param in favor of handling bigints inside of defaultSerializeQueryArgs

Author: rkofman

packages/toolkit/src/query/defaultSerializeQueryArgs.ts

@@ -9,7 +9,6 @@ const cache: WeakMap<any, string> | undefined = WeakMap
 export const defaultSerializeQueryArgs: SerializeQueryArgs<any> = ({
   endpointName,
   queryArgs,
-  replacer,
 }) => {
   let serialized = ''
 
@@ -19,8 +18,8 @@ export const defaultSerializeQueryArgs: SerializeQueryArgs<any> = ({
     serialized = cached
   } else {
     const stringified = JSON.stringify(queryArgs, (key, value) => {
-      // Use custom replacer first before applying key-sorting behavior:
-      value = replacer ? replacer(key, value) : value
+      // Handle bigints
+      value = typeof value === 'bigint' ? { $bigint: value.toString() } : value
       // Sort the object keys before stringifying, to prevent useQuery({ a: 1, b: 2 }) having a different cache key than useQuery({ b: 2, a: 1 })
       value = isPlainObject(value)
         ? Object.keys(value)
@@ -44,14 +43,10 @@ export type SerializeQueryArgs<QueryArgs, ReturnType = string> = (_: {
   queryArgs: QueryArgs
   endpointDefinition: EndpointDefinition<any, any, any, any>
   endpointName: string
-  // Allows for a custom stringify replacer while keeping key-sorting behavior. e.g. for serializing bigint.
-  replacer?: (key: string, value: any) => {}
 }) => ReturnType
 
 export type InternalSerializeQueryArgs = (_: {
   queryArgs: any
   endpointDefinition: EndpointDefinition<any, any, any, any>
   endpointName: string
-  // Allows for a custom stringify replacer while keeping key-sorting behavior. e.g. for serializing bigint.
-  replacer?: (key: string, value: any) => {}
 }) => QueryCacheKey

packages/toolkit/src/query/react/buildHooks.ts

@@ -761,17 +761,14 @@ export function buildHooks<Definitions extends EndpointDefinitions>({
         subscriptionSelectorsRef.current =
           returnedValue as unknown as SubscriptionSelectors
       }
-      const bigIntReplacer = (_: string, value: any) =>
-        typeof value === 'bigint' ? { $bigint: value.toString() } : value
       const stableArg = useStableQueryArgs(
         skip ? skipToken : arg,
         // Even if the user provided a per-endpoint `serializeQueryArgs` with
         // a consistent return value, _here_ we want to use the default behavior
         // so we can tell if _anything_ actually changed. Otherwise, we can end up
         // with a case where the query args did change but the serialization doesn't,
         // and then we never try to initiate a refetch.
-        (params) =>
-          defaultSerializeQueryArgs({ replacer: bigIntReplacer, ...params }),
+        defaultSerializeQueryArgs,
         context.endpointDefinitions[name],
         name,
       )