Fix no-constant-condition related problems

Author: aryaemami59

packages/toolkit/src/listenerMiddleware/tests/useCases.test.ts

@@ -122,7 +122,7 @@ describe('Saga-style Effects Scenarios', () => {
         const pollingTask = listenerApi.fork(async (forkApi) => {
           pollingTaskStarted = true
           try {
-            while (true) {
+            while (pollingTaskStarted) {
               // Cancelation-aware pause for a new server message
               const serverEvent = await forkApi.pause(pollForEvent())
               // Process the message. In this case, just count the times we've seen this message.

packages/toolkit/src/query/retry.ts

@@ -142,6 +142,7 @@ const retryWithBackoff: BaseQueryEnhancer<
   }
   let retry = 0
 
+  // eslint-disable-next-line no-constant-condition
   while (true) {
     // Check if aborted before each attempt
     failIfAborted(api.signal)

packages/toolkit/src/query/tests/createApi.test.ts

@@ -21,7 +21,7 @@ import {
   createApi,
   fetchBaseQuery,
 } from '@reduxjs/toolkit/query'
-import { HttpResponse, delay, http } from 'msw'
+import { delay, http, HttpResponse } from 'msw'
 import nodeFetch from 'node-fetch'
 import * as v from 'valibot'
 import type { SchemaFailureHandler } from '../endpointDefinitions'
@@ -420,21 +420,6 @@ describe('endpoint definition typings', () => {
       const storeRef = setupApiStore(api, undefined, {
         withoutTestLifecycles: true,
       })
-      // only type-test this part
-      if (2 > 1) {
-        api.enhanceEndpoints({
-          endpoints: {
-            query1: {
-              // @ts-expect-error
-              providesTags: ['new'],
-            },
-            query2: {
-              // @ts-expect-error
-              providesTags: ['missing'],
-            },
-          },
-        })
-      }
 
       const enhanced = api.enhanceEndpoints({
         addTagTypes: ['new'],
@@ -461,22 +446,6 @@ describe('endpoint definition typings', () => {
       expect(consoleErrorSpy).toHaveBeenLastCalledWith(
         "Tag type 'missing' was used, but not specified in `tagTypes`!",
       )
-
-      // only type-test this part
-      if (2 > 1) {
-        enhanced.enhanceEndpoints({
-          endpoints: {
-            query1: {
-              // returned `enhanced` api contains "new" enitityType
-              providesTags: ['new'],
-            },
-            query2: {
-              // @ts-expect-error
-              providesTags: ['missing'],
-            },
-          },
-        })
-      }
     })
 
     test('modify', () => {

packages/toolkit/src/tests/createAsyncThunk.test-d.ts

@@ -1,3 +1,4 @@
+import type { TSVersion } from '@phryneas/ts-version'
 import type {
   AsyncThunk,
   SerializedError,
@@ -11,8 +12,6 @@ import {
   createSlice,
   unwrapResult,
 } from '@reduxjs/toolkit'
-
-import type { TSVersion } from '@phryneas/ts-version'
 import type { AxiosError } from 'axios'
 import apiRequest from 'axios'
 import type { AsyncThunkDispatchConfig } from '@internal/createAsyncThunk'
@@ -753,10 +752,11 @@ describe('type tests', () => {
 
       expectTypeOf(n).toBeNumber()
 
-      if (1 < 2)
-        // @ts-expect-error
-        return api.rejectWithValue(5)
-      if (1 < 2) return api.rejectWithValue('test')
+      expectTypeOf(api.rejectWithValue).parameter(0).not.toBeNumber()
+
+      expectTypeOf(api.rejectWithValue).toBeCallableWith('test')
+
+      if (api) return api.rejectWithValue('test')
       return test1 + test2
     })
 
@@ -783,7 +783,7 @@ describe('type tests', () => {
 
       expectTypeOf(n).toBeNumber()
 
-      if (1 < 2) expectTypeOf(api.rejectWithValue).toBeCallableWith('test')
+      expectTypeOf(api.rejectWithValue).toBeCallableWith('test')
 
       expectTypeOf(api.rejectWithValue).parameter(0).not.toBeNumber()
 
@@ -819,8 +819,7 @@ describe('type tests', () => {
 
         expectTypeOf(n).toBeNumber()
 
-        if (1 < 2) return api.rejectWithValue(5)
-        if (1 < 2) expectTypeOf(api.rejectWithValue).toBeCallableWith(5)
+        expectTypeOf(api.rejectWithValue).toBeCallableWith(5)
 
         expectTypeOf(api.rejectWithValue).parameter(0).not.toBeString()
 

packages/toolkit/src/tests/utils/helpers.tsx

@@ -44,7 +44,7 @@ export function withProvider(store: Store<any>) {
 export const hookWaitFor = async (cb: () => void, time = 2000) => {
   const startedAt = Date.now()
 
-  while (true) {
+  while (startedAt) {
     try {
       cb()
       return true
@@ -61,7 +61,7 @@ export const hookWaitFor = async (cb: () => void, time = 2000) => {
 export const fakeTimerWaitFor = async (cb: () => void, time = 2000) => {
   const startedAt = Date.now()
 
-  while (true) {
+  while (startedAt) {
     try {
       cb()
       return true