Fix @typescript-eslint/no-unused-expressions related issues

Author: aryaemami59

packages/toolkit/src/immutableStateInvariantMiddleware.ts

@@ -1,5 +1,6 @@
 import type { Middleware } from 'redux'
 import type { IgnorePaths } from './serializableStateInvariantMiddleware'
+import type { AnyObject } from './tsHelpers'
 import { getTimeMeasureUtils } from './utils'
 
 type EntryProcessor = (key: string, value: any) => any
@@ -190,8 +191,16 @@ export function createImmutableStateInvariantMiddleware(
       return function (this: any, key: string, value: any) {
         if (stack.length > 0) {
           const thisPos = stack.indexOf(this)
-          ~thisPos ? stack.splice(thisPos + 1) : stack.push(this)
-          ~thisPos ? keys.splice(thisPos, Infinity, key) : keys.push(key)
+          if (~thisPos) {
+            stack.splice(thisPos + 1)
+          } else {
+            stack.push(this)
+          }
+          if (~thisPos) {
+            keys.splice(thisPos, Infinity, key)
+          } else {
+            keys.push(key)
+          }
           if (~stack.indexOf(value)) value = decycler!.call(this, key, value)
         } else stack.push(value)
 

packages/toolkit/src/query/tests/cacheCollection.test.ts

@@ -87,8 +87,8 @@ test(`query: handles large keepUnuseDataFor values over 32-bit ms`, async () =>
   expect(onCleanup).not.toHaveBeenCalled()
 
   // _Should_ be called _wayyyy_ in the future (like 24.8 days from now)
-  vi.advanceTimersByTime(THIRTY_TWO_BIT_MAX_TIMER_SECONDS * 1000),
-    expect(onCleanup).toHaveBeenCalled()
+  vi.advanceTimersByTime(THIRTY_TWO_BIT_MAX_TIMER_SECONDS * 1000)
+  expect(onCleanup).toHaveBeenCalled()
 })
 
 describe(`query: await cleanup, keepUnusedDataFor set`, () => {

packages/toolkit/src/tests/createDraftSafeSelector.withTypes.test.ts

@@ -44,6 +44,6 @@ describe(createDraftSafeSelector.withTypes, () => {
       (todos) => todos.map(({ id }) => id),
     )
 
-    expect(selectTodoIds(rootState)).to.be.an('array').that.is.not.empty
+    expect(selectTodoIds(rootState)).to.be.an('array').with.lengthOf(2)
   })
 })