Fix issue with isValidElementType invariant check crashing on valid type with circular structure (#1122)

Author: Andarist

CONTRIBUTING.md

@@ -42,12 +42,12 @@ npm run test
 
 To run in explicit React versions (the number is the version, so `test:16.3` will run in React version `16.3`):
 ```
-REACT=16.4 npm run test:ci
+REACT=16.4 npm run test
 ```
 
 To run tests in all supported React versions, `16.4`, 16.5`,
 ```
-REACT=all npm run test:ci
+REACT=all npm run test
 ```
 
 To continuously watch and run tests, run the following:

package-lock.json

@@ -5,6 +5,14 @@ import { isValidElementType } from 'react-is'
 
 import { ReactReduxContext } from './Context'
 
+const stringifyComponent = Comp => {
+  try {
+    return JSON.stringify(Comp)
+  } catch (err) {
+    return String(Comp)
+  }
+}
+
 export default function connectAdvanced(
   /*
     selectorFactory is a func that is responsible for returning the selector function used to
@@ -86,7 +94,9 @@ export default function connectAdvanced(
       invariant(
         isValidElementType(WrappedComponent),
         `You must pass a component to the function returned by ` +
-          `${methodName}. Instead received ${JSON.stringify(WrappedComponent)}`
+          `${methodName}. Instead received ${stringifyComponent(
+            WrappedComponent
+          )}`
       )
     }
 

src/components/connectAdvanced.js

@@ -2604,5 +2604,19 @@ describe('React', () => {
         )(Comp)
       }).toThrow(/renderCountProp is removed/)
     })
+
+    it('should not error on valid component with circular structure', () => {
+      const createComp = Tag => {
+        const Comp = React.forwardRef(function Comp(props) {
+          return <Tag>{props.count}</Tag>
+        })
+        Comp.__real = Comp
+        return Comp
+      }
+
+      expect(() => {
+        connect()(createComp('div'))
+      }).not.toThrow()
+    })
   })
 })

test/components/connect.spec.js

@@ -27,4 +27,7 @@ if (version.toLowerCase() === 'all') {
   }
 }
 
-npmRun.execSync(`jest -c '${JSON.stringify(jestConfig)}'`, { stdio: 'inherit' })
+npmRun.execSync(
+  `jest -c '${JSON.stringify(jestConfig)}' ${process.argv.slice(2).join(' ')}`,
+  { stdio: 'inherit' }
+)