#227 - Junk variables in multi_text removed.

kprovance · kprovance · commit a04797622357 · 2021-06-29T14:49:39.000-04:00
Signed-off-by: Kevin Provance &lt;kevin.provance@gmail.com&gt;
diff --git a/redux-core/inc/fields/multi_text/class-redux-multi-text.php b/redux-core/inc/fields/multi_text/class-redux-multi-text.php
@@ -44,7 +44,7 @@ public function render() {
 
 			if ( isset( $this->value ) && is_array( $this->value ) ) {
 				foreach ( $this->value as $k => $value ) {
-					if ( '' !== $value || ( true === $this->show_empty ) ) {
+					if ( '' !== $value || ( true === $this->field['show_empty'] ) ) {
 						echo '<li>';
 						echo '<input
 								type="text"
@@ -61,7 +61,7 @@ class="deletion redux-multi-text-remove">' .
 						echo '</li>';
 					}
 				}
-			} elseif ( true === $this->show_empty ) {
+			} elseif ( true === $this->field['show_empty'] ) {
 				echo '<li>';
 				echo '<input
 						type="text"
@@ -80,7 +80,7 @@ class="deletion redux-multi-text-remove">' .
 			}
 
 			$the_name = '';
-			if ( isset( $this->value ) && empty( $this->value ) && false === $this->show_empty ) {
+			if ( isset( $this->value ) && empty( $this->value ) && false === $this->field['show_empty'] ) {
 				$the_name = $this->field['name'] . $this->field['name_suffix'];
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ public function render() {`
`44`	`44`
`45`	`45`	`if ( isset( $this->value ) && is_array( $this->value ) ) {`
`46`	`46`	`foreach ( $this->value as $k => $value ) {`
`47`		`- if ( '' !== $value \|\| ( true === $this->show_empty ) ) {`
	`47`	`+ if ( '' !== $value \|\| ( true === $this->field['show_empty'] ) ) {`
`48`	`48`	`echo '<li>';`
`49`	`49`	`echo '<input`
`50`	`50`	`type="text"`
`@@ -61,7 +61,7 @@ class="deletion redux-multi-text-remove">' .`
`61`	`61`	`echo '</li>';`
`62`	`62`	`}`
`63`	`63`	`}`
`64`		`- } elseif ( true === $this->show_empty ) {`
	`64`	`+ } elseif ( true === $this->field['show_empty'] ) {`
`65`	`65`	`echo '<li>';`
`66`	`66`	`echo '<input`
`67`	`67`	`type="text"`
`@@ -80,7 +80,7 @@ class="deletion redux-multi-text-remove">' .`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`$the_name = '';`
`83`		`- if ( isset( $this->value ) && empty( $this->value ) && false === $this->show_empty ) {`
	`83`	`+ if ( isset( $this->value ) && empty( $this->value ) && false === $this->field['show_empty'] ) {`
`84`	`84`	`$the_name = $this->field['name'] . $this->field['name_suffix'];`
`85`	`85`	`}`
`86`	`86`