Merge pull request #3 from redislabs-training/fix-undefined-nan

Fixes issues with isNan and undefined.

Author: Simon Prickett

package-lock.json

@@ -12,7 +12,7 @@ const controller = require('../controllers/capacity_controller');
  *  passed in, otherwise 10 as a default.
  * @private
  */
-const getLimit = n => (Number.isNaN(n) ? 10 : n);
+const getLimit = n => (Number.isNaN(n) || undefined === n ? 10 : n);
 
 // GET /capacity?limit=99
 router.get(

src/routes/capacity_routes.js

@@ -12,7 +12,7 @@ const controller = require('../controllers/meterreadings_controller');
  * @private
  */
 const getLimit = (n) => {
-  if (Number.isNaN(n)) {
+  if (Number.isNaN(n) || undefined === n) {
     return 100;
   }
 

src/routes/meterreadings_routes.js

@@ -13,7 +13,8 @@ router.get(
   ],
   async (req, res, next) => {
     try {
-      const limit = (req.query.n == null || Number.isNaN(req.query.n)) ? 120 : req.query.n;
+      const limit = (req.query.n == null || Number.isNaN(req.query.n)
+                     || undefined === req.query.n) ? 120 : req.query.n;
 
       const siteMetricsReport = await controller.getMetricsForSite(req.params.siteId, limit);
       return res.status(200).json(siteMetricsReport);