fix url vs redis_url (#289)

There was a bug in from_existing where it was not passing the redis_url
correctly because the var is named `url`

![image](https://github.com/user-attachments/assets/f350264f-debb-4382-ad40-be38a3609cb3)

Author: rbs333

redisvl/cli/index.py

@@ -79,7 +79,7 @@ def listall(self, args: Namespace):
             rvl index listall
         """
         redis_url = create_redis_url(args)
-        conn = RedisConnectionFactory.get_redis_connection(redis_url)
+        conn = RedisConnectionFactory.get_redis_connection(redis_url=redis_url)
         indices = convert_bytes(conn.execute_command("FT._LIST"))
         logger.info("Indices:")
         for i, index in enumerate(indices):
@@ -107,7 +107,7 @@ def _connect_to_index(self, args: Namespace) -> SearchIndex:
         # connect to redis
         try:
             redis_url = create_redis_url(args)
-            conn = RedisConnectionFactory.get_redis_connection(url=redis_url)
+            conn = RedisConnectionFactory.get_redis_connection(redis_url=redis_url)
         except ValueError:
             logger.error(
                 "Must set REDIS_URL environment variable or provide host and port"

redisvl/index/index.py

@@ -358,7 +358,7 @@ def _redis_client(self) -> Optional[redis.Redis]:
             with self._lock:
                 if self.__redis_client is None:
                     self.__redis_client = RedisConnectionFactory.get_redis_connection(
-                        url=self._redis_url,
+                        redis_url=self._redis_url,
                         **self._connection_kwargs,
                     )
         return self.__redis_client

redisvl/redis/connection.py

@@ -223,7 +223,7 @@ def connect(
 
     @staticmethod
     def get_redis_connection(
-        url: Optional[str] = None,
+        redis_url: Optional[str] = None,
         required_modules: Optional[List[Dict[str, Any]]] = None,
         **kwargs,
     ) -> Redis:
@@ -245,7 +245,7 @@ def get_redis_connection(
                 variable is not set.
             RedisModuleVersionError: If required Redis modules are not installed.
         """
-        url = url or get_address_from_env()
+        url = redis_url or get_address_from_env()
         client = Redis.from_url(url, **kwargs)
 
         RedisConnectionFactory.validate_sync_redis(

tests/conftest.py

@@ -63,7 +63,7 @@ def client(redis_url):
     """
     A sync Redis client that uses the dynamic `redis_url`.
     """
-    conn = RedisConnectionFactory.get_redis_connection(redis_url)
+    conn = RedisConnectionFactory.get_redis_connection(redis_url=redis_url)
     yield conn
 
 

tests/integration/test_search_index.py

@@ -84,6 +84,17 @@ def test_search_index_from_existing(client, index):
     assert index2.schema == index.schema
 
 
+def test_search_index_from_existing_url(redis_url, index):
+    index.create(overwrite=True)
+
+    try:
+        index2 = SearchIndex.from_existing(index.name, redis_url=redis_url)
+    except Exception as e:
+        pytest.skip(str(e))
+
+    assert index2.schema == index.schema
+
+
 def test_search_index_from_existing_complex(client):
     schema = {
         "index": {