Fixed the tests and the resp parser

Author: peperon

redis/_parsers/helpers.py

@@ -163,7 +163,7 @@ def parse_sentinel_masters(response, **options):
 
 
 def parse_sentinel_masters_resp3(response, **options):
-    return [parse_sentinel_state(master) for master in response]
+    return [parse_sentinel_state_resp3(master) for master in response]
 
 
 def parse_sentinel_slaves_and_sentinels(response, **options):

tests/test_asyncio/test_sentinel.py

@@ -13,6 +13,7 @@
     SentinelConnectionPool,
     SlaveNotFoundError,
 )
+from tests.conftest import is_resp2_connection
 
 
 @pytest_asyncio.fixture(scope="module", loop_scope="module")
@@ -381,7 +382,13 @@ async def test_sentinel_commands_with_strict_redis_client(request):
         await client.sentinel_get_master_addr_by_name("redis-py-test"), tuple
     )
     assert isinstance(await client.sentinel_master("redis-py-test"), dict)
-    assert isinstance(await client.sentinel_masters(), dict)
+    if is_resp2_connection(client):
+        assert isinstance(await client.sentinel_masters(), dict)
+    else:
+        masters = await client.sentinel_masters()
+        assert isinstance(masters, list)
+        for master in masters:
+            assert isinstance(master, dict)
 
     assert isinstance(await client.sentinel_sentinels("redis-py-test"), list)
     assert isinstance(await client.sentinel_slaves("redis-py-test"), list)

tests/test_sentinel.py

@@ -12,6 +12,7 @@
     SentinelConnectionPool,
     SlaveNotFoundError,
 )
+from tests.conftest import is_resp2_connection
 
 
 @pytest.fixture(scope="module")
@@ -358,7 +359,13 @@ def test_sentinel_commands_with_strict_redis_client(request):
     # skipping commands that change the state of the sentinel setup
     assert isinstance(client.sentinel_get_master_addr_by_name("redis-py-test"), tuple)
     assert isinstance(client.sentinel_master("redis-py-test"), dict)
-    assert isinstance(client.sentinel_masters(), dict)
+    if is_resp2_connection(client):
+        assert isinstance(client.sentinel_masters(), dict)
+    else:
+        masters = client.sentinel_masters()
+        assert isinstance(masters, list)
+        for master in masters:
+            assert isinstance(master, dict)
 
     assert isinstance(client.sentinel_sentinels("redis-py-test"), list)
     assert isinstance(client.sentinel_slaves("redis-py-test"), list)