Skip to content

Commit a21968c

Browse files
committed
Applying review comments
1 parent fd6c1e0 commit a21968c

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

tests/test_scenario/test_hitless_upgrade.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,16 @@
3030
)
3131

3232
logging.basicConfig(
33-
level=logging.DEBUG,
33+
level=logging.INFO,
3434
format="%(asctime)s %(levelname)s %(message)s",
35-
filemode="w",
36-
filename="./test_hitless_upgrade.log",
3735
)
3836

3937
BIND_TIMEOUT = 30
4038
MIGRATE_TIMEOUT = 60
4139
FAILOVER_TIMEOUT = 15
4240

41+
DEFAULT_BIND_TTL = 15
42+
4343

4444
class TestPushNotifications:
4545
"""
@@ -767,7 +767,7 @@ def execute_commands(moving_event: threading.Event, errors: Queue):
767767
assert errors.empty(), f"Errors occurred in threads: {errors.queue}"
768768

769769
logging.info("Waiting for moving ttl to expire")
770-
time.sleep(15)
770+
time.sleep(DEFAULT_BIND_TTL)
771771
bind_thread.join()
772772

773773
@pytest.mark.timeout(300) # 5 minutes timeout
@@ -1021,7 +1021,7 @@ def test_disabled_handling_during_migrating_and_moving(
10211021
)
10221022

10231023
logging.info("Waiting for moving ttl to expire")
1024-
time.sleep(20)
1024+
time.sleep(DEFAULT_BIND_TTL)
10251025

10261026
logging.info("Validating connection states after MOVING has expired ...")
10271027
self._validate_default_notif_disabled_state(

0 commit comments

Comments
 (0)