Adding vulture for static analysis (#1655)

* Adding vulture for static analysis

Removing dead code found previously by vulture in local runs.

Author: chayim

dev_requirements.txt

@@ -3,4 +3,5 @@ pytest==6.2.5
 tox==3.24.4
 tox-docker==3.1.0
 invoke==1.6.0
-pytest-cov>=3.0.0
+pytest-cov>=3.0.0
+vulture>=2.3.0

redis/connection.py

@@ -746,7 +746,6 @@ def can_read(self, timeout=0):
         sock = self._sock
         if not sock:
             self.connect()
-            sock = self._sock
         return self._parser.can_read(timeout)
 
     def read_response(self):

redis/features.py

@@ -23,7 +23,7 @@ def devenv(c):
 @task
 def linters(c):
     """Run code linters"""
-    run("flake8")
+    run("tox -e linters")
 
 
 @task

tasks.py

@@ -6,7 +6,7 @@ markers =
 [tox]
 minversion = 3.2.0
 requires = tox-docker
-envlist = {py35,py36,py37,py38,py39,pypy3}-{plain,hiredis}, flake8
+envlist = {py35,py36,py37,py38,py39,pypy3}-{plain,hiredis},linters
 
 [docker:master]
 name = master
@@ -102,9 +102,12 @@ docker =
     lots-of-pythons
 commands = /usr/bin/echo
 
-[testenv:flake8]
+[testenv:linters]
 deps_files = dev_requirements.txt
-commands = flake8
+docker=
+commands =
+    flake8
+    vulture redis whitelist.py --min-confidence 80
 skipsdist = true
 skip_install = true
 
@@ -114,18 +117,8 @@ basepython = pypy3
 [testenv:pypy3-hiredis]
 basepython = pypy3
 
-#[testenv:codecov]
-#deps = codecov
-#commands = codecov
-#passenv =
-#  REDIS_*
-#  CI
-#  CI_*
-#  CODECOV_*
-#  SHIPPABLE
-#  GITHUB_*
-#  VCS_*
-#
-#[testenv:covreport]
-#deps = coverage
-#commands = coverage report
+[flake8]
+exclude =
+    .venv,
+    .tox,
+    whitelist.py

tox.ini

@@ -0,0 +1,12 @@
+exc_type  # unused variable (/data/repos/redis/redis-py/redis/client.py:1045)
+exc_value  # unused variable (/data/repos/redis/redis-py/redis/client.py:1045)
+traceback  # unused variable (/data/repos/redis/redis-py/redis/client.py:1045)
+exc_type  # unused variable (/data/repos/redis/redis-py/redis/client.py:1211)
+exc_value  # unused variable (/data/repos/redis/redis-py/redis/client.py:1211)
+traceback  # unused variable (/data/repos/redis/redis-py/redis/client.py:1211)
+exc_type  # unused variable (/data/repos/redis/redis-py/redis/client.py:1589)
+exc_value  # unused variable (/data/repos/redis/redis-py/redis/client.py:1589)
+traceback  # unused variable (/data/repos/redis/redis-py/redis/client.py:1589)
+exc_type  # unused variable (/data/repos/redis/redis-py/redis/lock.py:156)
+exc_value  # unused variable (/data/repos/redis/redis-py/redis/lock.py:156)
+traceback  # unused variable (/data/repos/redis/redis-py/redis/lock.py:156)