From de75914d261092bf594d3baa07d61b8ef1322b77 Mon Sep 17 00:00:00 2001
From: Maria Markova <maria.markova@intel.com>
Date: Thu, 13 Nov 2025 16:23:58 +0100
Subject: [PATCH] Fix TypeError for pubsub-sub-bench tests: add missing result
 path handler

- Add handler for pubsub-sub-bench in single-client result path construction
- Previously only memtier_benchmark and vector-db-benchmark had handlers
- This caused full_result_path to remain as bare filename without directory
- Add safety check before shutil.copy to prevent crashes and provide better error messages
- Fixes: TypeError when full_result_path is None for pubsub/mixed tests
---
 .../__runner__/runner.py                      | 25 +++++++++++++++----
 1 file changed, 20 insertions(+), 5 deletions(-)

diff --git a/redis_benchmarks_specification/__runner__/runner.py b/redis_benchmarks_specification/__runner__/runner.py
index 2d1fb6d..3c22948 100644
--- a/redis_benchmarks_specification/__runner__/runner.py
+++ b/redis_benchmarks_specification/__runner__/runner.py
@@ -2948,6 +2948,10 @@ def delete_temporary_files(
                             full_result_path = "{}/{}".format(
                                 temporary_dir_client, local_benchmark_output_filename
                             )
+                        elif "pubsub-sub-bench" in benchmark_tool:
+                            full_result_path = "{}/{}".format(
+                                temporary_dir_client, local_benchmark_output_filename
+                            )
                         elif "vector-db-benchmark" in benchmark_tool:
                             # For vector-db-benchmark, look for summary JSON file
                             summary_files = [
@@ -3123,12 +3127,23 @@ def delete_temporary_files(
                         client_aggregated_results_folder,
                         local_benchmark_output_filename,
                     )
-                    logging.info(
-                        "Preserving local results file {} into {}".format(
-                            full_result_path, dest_fpath
+                    # Safety check: ensure full_result_path exists before copying
+                    if full_result_path is None:
+                        logging.error(
+                            f"Cannot preserve results: full_result_path is None for test {test_name}. "
+                            f"This may indicate a missing benchmark tool handler in the result path construction."
                         )
-                    )
-                    shutil.copy(full_result_path, dest_fpath)
+                    elif not os.path.exists(full_result_path):
+                        logging.error(
+                            f"Cannot preserve results: file does not exist at {full_result_path} for test {test_name}"
+                        )
+                    else:
+                        logging.info(
+                            "Preserving local results file {} into {}".format(
+                                full_result_path, dest_fpath
+                            )
+                        )
+                        shutil.copy(full_result_path, dest_fpath)
                 overall_result &= test_result
 
                 delete_temporary_files(