Skip to content

Commit e862c9e

Browse files
Removed arbitrary command escape on cluster mode and memtier (#311)
1 parent 37282e9 commit e862c9e

File tree

1 file changed

+0
-21
lines changed
  • redis_benchmarks_specification/__runner__

1 file changed

+0
-21
lines changed

redis_benchmarks_specification/__runner__/runner.py

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2210,21 +2210,6 @@ def delete_temporary_files(
22102210
)
22112211
arbitrary_command = False
22122212

2213-
if (
2214-
arbitrary_command
2215-
and oss_cluster_api_enabled
2216-
and "memtier" in benchmark_tool
2217-
):
2218-
logging.warning(
2219-
"Forcing skip this test given there is an arbitrary commmand and memtier usage. Check https://github.com/RedisLabs/memtier_benchmark/pull/117 ."
2220-
)
2221-
delete_temporary_files(
2222-
temporary_dir_client=temporary_dir_client,
2223-
full_result_path=None,
2224-
benchmark_tool_global=benchmark_tool_global,
2225-
)
2226-
continue
2227-
22282213
# Check if we have multiple client configurations
22292214
client_configs = extract_client_configs(benchmark_config)
22302215
is_multiple_clients = len(client_configs) > 1
@@ -3375,12 +3360,6 @@ def data_prepopulation_step(
33753360
1,
33763361
unix_socket,
33773362
)
3378-
if arbitrary_command is True and oss_cluster_api_enabled:
3379-
logging.warning(
3380-
"Skipping this test given it implies arbitrary command on an cluster setup. Not supported on memtier: https://github.com/RedisLabs/memtier_benchmark/pull/117"
3381-
)
3382-
result = False
3383-
return result
33843363

33853364
# run the benchmark
33863365
preload_start_time = datetime.datetime.now()

0 commit comments

Comments
 (0)