Skip to content

Rebuild after release - fix #3118 #3120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Rebuild after release - fix #3118 #3120

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d1e84d
Rebuild after release - fix #3118
zingazzi Oct 30, 2025
81760c4
Add release hook
zingazzi Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,7 @@ jobs:
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

# Rebuild packages after version bump to ensure dist/package.json is updated
Copy link

@jannis-adamek-dt jannis-adamek-dt Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi :) Isn't the package then already on the NPM registry with the previous npm run releases step?

Copy link
Author

@zingazzi zingazzi Oct 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absoluty right! Sorry my fault. I think another solution to fix this error can be add an Hook in release-it.json.

Something like this

"hooks": {
    "before:release": "npm run build"
  }

What do you think about this solution?

Copy link

@jannis-adamek-dt jannis-adamek-dt Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with these hooks but it sounds reasonable to me.

Copy link
Author

@zingazzi zingazzi Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've update the hook. Feel free to merge it if you consider it a valid solution.
Thank you for your patience.

- name: Rebuild packages after version bump
run: npm run build