chore: various small improvements

* add _self in client
* measure tmp client creation
* improve logging
* set relaxed timeouts on tmp client

Author: nkaradzhov

packages/client/lib/client/commands-queue.ts

@@ -87,6 +87,7 @@ export default class RedisCommandsQueue {
     this.#maintenanceCommandTimeout = ms;
 
     let counter = 0;
+    const total = this.#toWrite.length;
 
     // Overwrite timeouts of all eligible toWrite commands
     for(const node of this.#toWrite.nodes()) {
@@ -114,7 +115,7 @@ export default class RedisCommandsQueue {
       };
       signal.addEventListener('abort', command.timeout.listener, { once: true });
     };
-    dbgMaintenance(`Total of ${counter} timeouts reset to ${ms}`);
+    dbgMaintenance(`Total of ${counter} of ${total} timeouts reset to ${ms}`);
   }
 
   get isPubSubActive() {

packages/client/lib/client/enterprise-maintenance-manager.ts

@@ -181,18 +181,24 @@ export default class EnterpriseMaintenanceManager {
     dbgMaintenance("Pausing writing of new commands to old socket");
     this.#client._pause();
 
+    dbgMaintenance("Creating new tmp client");
+    let start = performance.now();
     const tmpClient = this.#client.duplicate({
-      maintPushNotifications: "disabled",
       socket: {
         ...this.#options.socket,
         host,
         port,
       },
     });
-
+    dbgMaintenance(`Tmp client created in ${( performance.now() - start ).toFixed(2)}ms`);
     dbgMaintenance(`Connecting tmp client: ${host}:${port}`);
+    start = performance.now();
+    tmpClient._maintenanceUpdate({
+      relaxedCommandTimeout: this.#options.maintRelaxedCommandTimeout,
+      relaxedSocketTimeout: this.#options.maintRelaxedSocketTimeout,
+    });
     await tmpClient.connect();
-    dbgMaintenance(`Connected to tmp client`);
+    dbgMaintenance(`Connected to tmp client in ${(performance.now() - start).toFixed(2)}ms`);
     // 3 [EVENT] New socket connected
 
     //TODO

packages/client/lib/client/index.ts

@@ -937,7 +937,7 @@ export default class RedisClient<
    _ejectSocket(): RedisSocket {
      const socket = this._self.#socket;
      // @ts-ignore
-     this.#socket = null;
+     this._self.#socket = null;
      socket.removeAllListeners();
      return socket;
    }
@@ -957,10 +957,10 @@ export default class RedisClient<
     * @internal
     */
    _maintenanceUpdate(update: MaintenanceUpdate) {
-     this.#socket.inMaintenance = update.inMaintenance;
-     this.#socket.setMaintenanceTimeout(update.relaxedSocketTimeout);
-     this.#queue.inMaintenance = update.inMaintenance;
-     this.#queue.setMaintenanceCommandTimeout(update.relaxedCommandTimeout);
+     this._self.#socket.inMaintenance = update.inMaintenance;
+     this._self.#socket.setMaintenanceTimeout(update.relaxedSocketTimeout);
+     this._self.#queue.inMaintenance = update.inMaintenance;
+     this._self.#queue.setMaintenanceCommandTimeout(update.relaxedCommandTimeout);
    }
 
    /**