fix(sentinel): propagate RESP option to clients (#3011)

`createSentinel` takes RESP as an option, but does not propagate down
to the actual clients. This creates confusion for the users as they
expect the option to be set to all clients, which is reasonable.

In case of clientSideCaching, this problem manifests as validation failure
because clientSideCaching requires RESP3, but if we dont propagate,
clients start with the default RESP2

fixes #3010

Author: nkaradzhov

packages/client/lib/sentinel/index.spec.ts

@@ -23,7 +23,7 @@ describe('RedisSentinel', () => {
           { host: 'localhost', port: 26379 }
         ]
       };
-      
+
       it('should throw error when clientSideCache is enabled with RESP 2', () => {
         assert.throws(
           () => RedisSentinel.create({
@@ -46,14 +46,24 @@ describe('RedisSentinel', () => {
       });
 
       it('should not throw when clientSideCache is enabled with RESP 3', () => {
-        assert.doesNotThrow(() => 
+        assert.doesNotThrow(() =>
           RedisSentinel.create({
             ...options,
             clientSideCache: clientSideCacheConfig,
             RESP: 3 as const,
           })
         );
       });
+
+      testUtils.testWithClientSentinel('should successfully connect to sentinel', async () => {
+      }, {
+        ...GLOBAL.SENTINEL.OPEN,
+        sentinelOptions: {
+          RESP: 3,
+          clientSideCache: { ttl: 0, maxEntries: 0, evictPolicy: 'LRU'},
+        },
+      })
+
     });
   });
 });
@@ -417,7 +427,7 @@ async function steadyState(frame: SentinelFramework) {
     sentinel.setTracer(tracer);
     await sentinel.connect();
     await nodePromise;
-    
+
     await sentinel.flushAll();
   } finally {
     if (sentinel !== undefined) {
@@ -443,7 +453,7 @@ describe('legacy tests', () => {
       this.timeout(15000);
 
       last = Date.now();
-  
+
       function deltaMeasurer() {
         const delta = Date.now() - last;
         if (delta > longestDelta) {
@@ -508,7 +518,7 @@ describe('legacy tests', () => {
       }
 
       stopMeasuringBlocking = true;
-  
+
       await frame.cleanup();
     })
 
@@ -1032,6 +1042,3 @@ describe('legacy tests', () => {
     })
   });
 });
-
-
-

packages/client/lib/sentinel/index.ts

@@ -625,6 +625,7 @@ class RedisSentinelInternal<
   readonly #sentinelClientOptions: RedisClientOptions<typeof RedisSentinelModule, RedisFunctions, RedisScripts, RespVersions, TypeMapping, RedisTcpSocketOptions>;
   readonly #scanInterval: number;
   readonly #passthroughClientErrorEvents: boolean;
+  readonly #RESP?: RespVersions;
 
   #anotherReset = false;
 
@@ -673,6 +674,7 @@ class RedisSentinelInternal<
 
     this.#name = options.name;
 
+    this.#RESP = options.RESP;
     this.#sentinelRootNodes = Array.from(options.sentinelRootNodes);
     this.#maxCommandRediscovers = options.maxCommandRediscovers ?? 16;
     this.#masterPoolSize = options.masterPoolSize ?? 1;
@@ -716,6 +718,9 @@ class RedisSentinelInternal<
 
   #createClient(node: RedisNode, clientOptions: RedisClientOptions, reconnectStrategy?: undefined | false) {
     return RedisClient.create({
+      //first take the globally set RESP
+      RESP: this.#RESP,
+      //then take the client options, which can in theory overwrite it
       ...clientOptions,
       socket: {
         ...clientOptions.socket,

packages/test-utils/lib/index.ts

@@ -337,6 +337,7 @@ export default class TestUtils {
         port: promise.port
       }));
 
+
       const sentinel = createSentinel({
         name: 'mymaster', 
         sentinelRootNodes: rootNodes, 
@@ -352,6 +353,7 @@ export default class TestUtils {
         functions: options?.functions || {},
         masterPoolSize: options?.masterPoolSize || undefined,
         reserveClient: options?.reserveClient || false,
+        ...options?.sentinelOptions
       }) as RedisSentinelType<M, F, S, RESP, TYPE_MAPPING>;
 
       if (options.disableClientSetup) {