fix(redisotel): correct metrics.DialHook attrs (#2331)

scott20315 · web-flow · commit 7c4b92435024 · 2022-12-23T20:40:07.000+08:00
diff --git a/extra/redisotel/metrics.go b/extra/redisotel/metrics.go
@@ -193,7 +193,11 @@ func (mh *metricsHook) DialHook(hook redis.DialHook) redis.DialHook {
 
 		conn, err := hook(ctx, network, addr)
 
-		mh.createTime.Record(ctx, milliseconds(time.Since(start)), mh.attrs...)
+		attrs := make([]attribute.KeyValue, 0, len(mh.attrs)+1)
+		attrs = append(attrs, mh.attrs...)
+		attrs = append(attrs, statusAttr(err))
+
+		mh.createTime.Record(ctx, milliseconds(time.Since(start)), attrs...)
 		return conn, err
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,11 @@ func (mh *metricsHook) DialHook(hook redis.DialHook) redis.DialHook {`
`193`	`193`
`194`	`194`	`conn, err := hook(ctx, network, addr)`
`195`	`195`
`196`		`- mh.createTime.Record(ctx, milliseconds(time.Since(start)), mh.attrs...)`
	`196`	`+ attrs := make([]attribute.KeyValue, 0, len(mh.attrs)+1)`
	`197`	`+ attrs = append(attrs, mh.attrs...)`
	`198`	`+ attrs = append(attrs, statusAttr(err))`
	`199`	`+`
	`200`	`+ mh.createTime.Record(ctx, milliseconds(time.Since(start)), attrs...)`
`197`	`201`	`return conn, err`
`198`	`202`	`}`
`199`	`203`	`}`